Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pegtl] Update to 3.2.6 for MSVC and GCC fixes #24761

Merged
merged 3 commits into from
May 18, 2022

Conversation

wravery
Copy link
Contributor

@wravery wravery commented May 17, 2022

  • What does your PR fix?

    Recent versions of MSVC and GCC changed the behavior of built-in macros and template parsing, which breaks the PEGTL demangle function when it's used in cppgraphlgen. This shows up as a build break in the cppgraphqlgen port. This version of PEGTL includes workarounds/updates to work with these compiler versions.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All, Yes (removing cppgraphqlgen failures on Windows).

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@wravery
Copy link
Contributor Author

wravery commented May 17, 2022

@BillyONeal I think this will unblock the cppgraphqlgen port with the latest CI baselines/VMs.

@BillyONeal
Copy link
Member

OK, I pushed a commit to remove those from the baseline then. I didn't remove the Linux one since the comment there says it's about newer GCC needed rather than older.

@BillyONeal BillyONeal merged commit 2247b39 into microsoft:master May 18, 2022
@BillyONeal
Copy link
Member

Thanks for such a quick fix!

@wravery wravery deleted the pegtl branch May 18, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants