[libjpeg-turbo] Enable NEON intrinsics for ARM builds #24775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 261ca0dd4d458f9ea58fc7096b1eb1a68c47cfc8 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/l-/libjpeg-turbo.json b/versions/l-/libjpeg-turbo.json
index 857413f..6860f26 100644
--- a/versions/l-/libjpeg-turbo.json
+++ b/versions/l-/libjpeg-turbo.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "f3ab7c40b47aa03953467e7697d3eea7b60d624e",
+ "version": "2.1.3",
+ "port-version": 3
+ },
{
"git-tree": "dd9bb6eb0d4e28d2b3ef0d83b6b9ef736555621d",
"version": "2.1.3",
ZacWalk
changed the title
Neumann-A
reviewed
May 18, 2022
| @@ -15,7 +15,7 @@ vcpkg_from_github( | |||
| ) | |||
|
|
|||
| if(VCPKG_TARGET_ARCHITECTURE STREQUAL "arm" OR VCPKG_TARGET_ARCHITECTURE STREQUAL "arm64" OR (VCPKG_CMAKE_SYSTEM_NAME AND NOT VCPKG_CMAKE_SYSTEM_NAME STREQUAL "WindowsStore")) | |||
| set(LIBJPEGTURBO_SIMD -DWITH_SIMD=OFF) | |||
| set(LIBJPEGTURBO_SIMD -DWITH_SIMD=ON -DNEON_INTRINSICS=ON) | |||
There was a problem hiding this comment.
The question here is if NEON_INTRNSICS are valid on all arm architectures or not.
There was a problem hiding this comment.
There are runtime checks to determine if SIMD versions of routines should be called.
The intrinsics look compatible with ARMv7 and ARMv8.
I have only tested on Windows ARM64 devices though.
There was a problem hiding this comment.
This is consistent with what other ports do.
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 261ca0dd4d458f9ea58fc7096b1eb1a68c47cfc8 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/l-/libjpeg-turbo.json b/versions/l-/libjpeg-turbo.json
index 857413f..6860f26 100644
--- a/versions/l-/libjpeg-turbo.json
+++ b/versions/l-/libjpeg-turbo.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "f3ab7c40b47aa03953467e7697d3eea7b60d624e",
+ "version": "2.1.3",
+ "port-version": 3
+ },
{
"git-tree": "dd9bb6eb0d4e28d2b3ef0d83b6b9ef736555621d",
"version": "2.1.3",
JackBoosY
added
category:port-feature
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Enables NEON Intrinsics for ARM builds to improve performance. Performance testing using tjbench:
Which triplets are supported/not supported? Have you updated the CI baseline?
No - not needed.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/