Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mpg123] update to 1.29.3 and fixes #24381 #24805

Merged
merged 1 commit into from
May 24, 2022

Conversation

abique
Copy link
Contributor

@abique abique commented May 19, 2022

This PR fixes #24381

ports/mpg123/portfile.cmake Outdated Show resolved Hide resolved
ports/mpg123/portfile.cmake Outdated Show resolved Hide resolved
ports/mpg123/vcpkg.json Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2f0872b7d592635e8e4919d178650d549c211464 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index c6c4a7a..e1183cc 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4650,7 +4650,7 @@
     },
     "mpg123": {
       "baseline": "1.29.3",
-      "port-version": 1
+      "port-version": 0
     },
     "mpi": {
       "baseline": "1",
diff --git a/versions/m-/mpg123.json b/versions/m-/mpg123.json
index 7a6899a..59a3234 100644
--- a/versions/m-/mpg123.json
+++ b/versions/m-/mpg123.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "faa0a53172655002565b86efc8431a4e5bef577f",
+      "version": "1.29.3",
+      "port-version": 0
+    },
     {
       "git-tree": "f566632e0952022b99b3214eadd0705caed0d247",
       "version": "1.29.3",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2f0872b7d592635e8e4919d178650d549c211464 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index c6c4a7a..e1183cc 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4650,7 +4650,7 @@
     },
     "mpg123": {
       "baseline": "1.29.3",
-      "port-version": 1
+      "port-version": 0
     },
     "mpi": {
       "baseline": "1",
diff --git a/versions/m-/mpg123.json b/versions/m-/mpg123.json
index 7a6899a..49610b4 100644
--- a/versions/m-/mpg123.json
+++ b/versions/m-/mpg123.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "4a6a4d1c9d856a88391390a574fba708fc147a63",
+      "version": "1.29.3",
+      "port-version": 0
+    },
     {
       "git-tree": "f566632e0952022b99b3214eadd0705caed0d247",
       "version": "1.29.3",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 2f0872b7d592635e8e4919d178650d549c211464 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index c6c4a7a..e1183cc 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4650,7 +4650,7 @@
     },
     "mpg123": {
       "baseline": "1.29.3",
-      "port-version": 1
+      "port-version": 0
     },
     "mpi": {
       "baseline": "1",
diff --git a/versions/m-/mpg123.json b/versions/m-/mpg123.json
index 7a6899a..574a2e8 100644
--- a/versions/m-/mpg123.json
+++ b/versions/m-/mpg123.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "7a44dbf4a9343eb737ac73ef99b7e210fe0758a5",
+      "version": "1.29.3",
+      "port-version": 0
+    },
     {
       "git-tree": "f566632e0952022b99b3214eadd0705caed0d247",
       "version": "1.29.3",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for mpg123 have changed but the version was not updated
version: 1.29.3
old SHA: 7a44dbf4a9343eb737ac73ef99b7e210fe0758a5
new SHA: 4c5d61fec709068b1b0e1977196a23978feb00e0
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@abique
Copy link
Contributor Author

abique commented May 19, 2022

I don't understand what the CI errors are about.
Maybe it is a CI bug?

@Adela0814 Adela0814 added category:port-update The issue is with a library, which is requesting update new revision category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. labels May 20, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for mpg123 have changed but the version was not updated
version: 1.29.3
old SHA: 4c5d61fec709068b1b0e1977196a23978feb00e0
new SHA: 2b99f7a71d1996dc6a61c81a11a9a98805eba1c4
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@LilyWangLL LilyWangLL requested a review from Adela0814 May 23, 2022 09:19
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label May 24, 2022
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the update!

@ras0219-msft ras0219-msft merged commit eddbb40 into microsoft:master May 24, 2022
@abique abique deleted the mpg123-m1-fix branch May 24, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mpg123] Build error
5 participants