-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsoncons] Update to version 0.168.7 #24820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/jsoncons/portfile.cmake
ports/jsoncons/vcpkg.json
Outdated
"version": "0.168.7", | ||
"port-version": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version": "0.168.7", | |
"port-version": 1, | |
"version": "0.168.7", |
ports/jsoncons/vcpkg.json
Outdated
"version": "0.168.7", | ||
"port-version": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version": "0.168.7", | |
"port-version": 1, | |
"version": "0.168.7", |
Thanks for your PR! Can you please correct the Version field in the CONTROL file? You can get more information from maintainer-guide.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be okay now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 7e3dcf74e37034eea358934a90a11d618520e139 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index cfa8057..e2cf696 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3078,7 +3078,7 @@
},
"jsoncons": {
"baseline": "0.168.7",
- "port-version": 1
+ "port-version": 0
},
"jsoncpp": {
"baseline": "1.9.5",
diff --git a/versions/j-/jsoncons.json b/versions/j-/jsoncons.json
index 996d5b0..f8f88f4 100644
--- a/versions/j-/jsoncons.json
+++ b/versions/j-/jsoncons.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "0b8c944c42e73d64c7c4a3842fb3765dc3ea1e28",
+ "version": "0.168.7",
+ "port-version": 0
+ },
{
"git-tree": "6414ef8b55dcc841446bedb4133d574860968452",
"version": "0.168.7",
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/jsoncons/portfile.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/jsoncons/portfile.cmake
❤️ Thanks for continuing to maintain a great library :) |
Describe the pull request
What does your PR fix?
Fixes warning C4002 on windows with msvs2022 danielaparker/jsoncons#352,Array move constructor of basic_json copies provided array. danielaparker/jsoncons#355,Iterating an object and erasing members danielaparker/jsoncons#363,[csv] Exponential formatted numbers with leading zeros in exponent danielaparker/jsoncons#365,Issue with assignment of an object_iterator to const_object_iterator using empty object danielaparker/jsoncons#372
Which triplets are supported/not supported? Have you updated the CI baseline?
All
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes