-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nvtt] Control CUDA dependency, fix linkage #24888
Conversation
Note on CI results: The binary artifact for port |
Now examining another osg (port update) build issue in release build only, x64-windows:
and similar. Looking at the logs from the forced nvtt build failure.
x64-windows release uses no flag but probably should use
I see, it doesn't save the existing |
Now there is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's a lot of bugs. Thanks!
@ras0219-msft Is it intentional that |
What does your PR fix?
Fixes a warning about the unused debug postfix in the release build.
Fixes wrong CRT linkage for MSVC release builds.
Adds an opt-in feature which controls the CUDA dependency.
Fixes an installation order problem detected in a vcpkg CI build of port osg when port cuda wasn't installed, but needed by the cached nvtt package.
Other changes to port nvtt are out of scope for this PR.
Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no.
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/