[imgui] Add supports for features dx*-binding and metal-binding and osx-binding #24999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 30, 2022 02:35
LilyWangLL
added
category:port-feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
approved these changes
May 31, 2022
LilyWangLL
commented
May 31, 2022
| }, | ||
| "dx12-binding": { | ||
| "description": "Make available DirectX12 binding" | ||
| "description": "Make available DirectX12 binding", | ||
| "supports": "!x86 & windows & !uwp" |
There was a problem hiding this comment.
The related upstream issue of DirectX12 doesn't support x86: ocornut/imgui#1641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [imgui] build failure #24970, add supports for featuresdx*-bindingandmetal-bindingandosx-binding.