Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gts] Move to official upstream sources #25034

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

ras0219-msft
Copy link
Contributor

  • The existing port pulled from an unofficial mirror on GitHub
  • The patches we were applying to that unofficial mirror's CMake buildsystem replacement were substantially longer than the buildsystem itself
  • I pregenerated predicates_init.h; it only served to make the buildsystem more complicated. Theoretically if you have a strange architecture you'll need to overlay the port and generate your own, but the method used requires running the generator on the target machine.
  • I've documented how to consume its .pc file in a way that won't introduce find_dependency requirements.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gts/vcpkg.json

Valid values for the license field can be found in the documentation

@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Jun 2, 2022
ports/gts/portfile.cmake Outdated Show resolved Hide resolved
@Cheney-W
Copy link
Contributor

Cheney-W commented Jun 2, 2022

@ras0219-msft Could you please add double quotations for all of the paths in portfile.cmake file?

@Cheney-W Cheney-W added requires:author-response info:internal This PR or Issue was filed by the vcpkg team. labels Jun 2, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gts/vcpkg.json

Valid values for the license field can be found in the documentation

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 7, 2022
@ras0219-msft ras0219-msft merged commit 053c82f into microsoft:master Jun 7, 2022
@ras0219-msft ras0219-msft deleted the dev/roschuma/gts branch June 7, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants