Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[igraph] update to 0.9.9 #25065

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Conversation

szhorvat
Copy link
Contributor

@szhorvat szhorvat commented Jun 4, 2022

Describe the pull request

  • What does your PR fix?

    Updated igraph to 0.9.9.
    Fixed UWP compatibility.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@szhorvat szhorvat changed the title Igraph 0.9.9 [igraph] update to 0.9.9 Jun 4, 2022
@szhorvat szhorvat marked this pull request as ready for review June 4, 2022 10:12
@szhorvat
Copy link
Contributor Author

szhorvat commented Jun 4, 2022

@Neumann-A I noticed you added supports: "!uwp" to this port since last time I was here. Can you clarify what would be required from igraph to add support? Are there any forbidden function calls?

@Neumann-A
Copy link
Contributor

@Neumann-A I noticed you added supports: "!uwp" to this port since last time I was here. Can you clarify what would be required from igraph to add support? Are there any forbidden function calls?

Probably. It was cascade before the uwp uses ninja change.

@szhorvat
Copy link
Contributor Author

szhorvat commented Jun 5, 2022

Could you give me a hint on how to identify the issues? I only have limited access to Windows (in a VM), thus debugging this is costly in time. I assume there's more to it than compiling with /ZW as CMake alone fails when using that option.

@Neumann-A
Copy link
Contributor

Could you give me a hint on how to identify the issues?

Remove the supports line and you get the error from vcpkg CI. Just need to download the logs then.

@szhorvat szhorvat marked this pull request as draft June 5, 2022 18:32
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for igraph have changed but the version was not updated
version: 0.9.9
old SHA: 221ce555ec3b30ef3e8cce65453deffc8e7b3547
new SHA: f03d10d0fec9efe63346ab0773906a60451a09a5
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for igraph have changed but the version was not updated
version: 0.9.9
old SHA: 221ce555ec3b30ef3e8cce65453deffc8e7b3547
new SHA: b1f35ac1b0cde77ebfbd3b48eeaf123b85ecc911
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@szhorvat szhorvat marked this pull request as ready for review June 5, 2022 21:01
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 6, 2022
@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 6, 2022
@ras0219-msft ras0219-msft merged commit 64ede84 into microsoft:master Jun 6, 2022
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants