Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buck-yeh-bux] Upgrade to 1.6.5 #25072

Merged
merged 69 commits into from
Jun 6, 2022
Merged

[buck-yeh-bux] Upgrade to 1.6.5 #25072

merged 69 commits into from
Jun 6, 2022

Conversation

buck-yeh
Copy link
Contributor

@buck-yeh buck-yeh commented Jun 4, 2022

Bug/quirk fixes & enhancements with minor breakage of includes

  1. [Bug] C_EZArgs::parse() misunderstands negative numbers as flag short names.
  2. [Bug] C_ScannerImpl<>::add() may throw due to losing its track of the last non-null action function pointer.
  3. [Quirk] C_EZArgs::help_full(): Keep "USAGE:" a empty line away from "DESCRIPTION:"
  4. [Dependency] Update according to the reported issue related to vcpkg build.
  5. [Obsolete] Remove ParaUtil.h(bux::C_NumIter<>) due to deprecation of std::iterator<>
  6. [Change] Parameters trigger & parse of all C_EZArgs::add_flag() overloads now passed by rvalue references for better performance.
  7. [Change] Loose the container parameter type requirements of C_PathFmtLogSnap::configPath(uintmax_t fsize_in_bytes, const auto &fallbackPaths)
  8. [Change] Replace DEF_CONFIGURABLE_LOGGER_FILES with DEF_FALLBACKABLE_LOGGER_FILES(first,...) to initialize the global logger in place.
  9. [Change] Move HRTN() & OXCPT() from LogStream.h to StrUtil.h.
  10. [Change] Rewrite I/O manipulator bux::timestamp utilizing fmt::format() to shorten the boilerplate code.
  11. [Change] Quit assuming std::string::begin() is defined as const char * upon implementing ctor of bux::C_IMemBuf.
  12. [Change] Harden the criteria to make flag values prefixed with '-' (negative numbers) hardly missed (i.e. misunderstood as short-named flags).
  13. [Change] Claim that "Behavior of adding duplicate subcommands or flags of the same name is undefined." i.e it is caller's responsibility.
  14. [Change] No more prepend ./ to the command name of USAGE part of help text.
  15. [Change] Allow bux::scanFile() to provide encoding code of the input stream. The change has a virtue of preventing short strings from guessing the wrong encoding.
  16. [Change] Were C_ScannerImpl<>::add() thrown, the incorporated message will have value of m_CurState.
  • What does your PR fix?

    Nothing

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Supported

    • x64-windows
    • x64-windows-static
    • x64-windows-static-md
    • x86-windows
    • x86-windows-static
    • x86-windows-static-md

    No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

buck-yeh and others added 30 commits August 18, 2021 03:35
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/buck-yeh-bux/vcpkg.json b/ports/buck-yeh-bux/vcpkg.json
index 4a8859a3..b578b6f5 100644
--- a/ports/buck-yeh-bux/vcpkg.json
+++ b/ports/buck-yeh-bux/vcpkg.json
@@ -1,7 +1,6 @@
 {
   "name": "buck-yeh-bux",
   "version": "1.6.5",
-  "port-version": 0,
   "description": "A supplemental C++ library with functionalities not directly supported from Modern C++ standard.",
   "homepage": "https://github.com/buck-yeh/bux",
   "supports": "!(arm | uwp | osx)",
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for buck-yeh-bux have changed but the version was not updated
version: 1.6.5
old SHA: 6f26e14a9cf36df1b0a5e705bc6d2f64bf508749
new SHA: 1ece7aafb4e23d83f4b8e46558c42b7c0d7f5b27
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/buck-yeh-bux/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/buck-yeh-bux/vcpkg.json b/ports/buck-yeh-bux/vcpkg.json
index fae64f3f..7465a14d 100644
--- a/ports/buck-yeh-bux/vcpkg.json
+++ b/ports/buck-yeh-bux/vcpkg.json
@@ -1,11 +1,10 @@
 {
   "name": "buck-yeh-bux",
   "version": "1.6.5",
-  "port-version": 0,
   "description": "A supplemental C++ library with functionalities not directly supported from Modern C++ standard.",
   "homepage": "https://github.com/buck-yeh/bux",
-  "supports": "!(arm | uwp | osx)",
   "license": "MIT",
+  "supports": "!(arm | uwp | osx)",
   "dependencies": [
     "fmt",
     {
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for buck-yeh-bux have changed but the version was not updated
version: 1.6.5
old SHA: 6f26e14a9cf36df1b0a5e705bc6d2f64bf508749
new SHA: 1fd8af12a04b806faa041b8631ac34dc8c535b41
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 6, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 6, 2022
@ras0219-msft ras0219-msft merged commit 67c2bdc into microsoft:master Jun 6, 2022
@ras0219-msft
Copy link
Contributor

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants