-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hdf5] Refix msmpi library path in pkgconfig #25089
Merged
vicroms
merged 9 commits into
microsoft:master
from
JackBoosY:dev/jack/re-fix-hdf5-mpi-pkgconfig
Jun 15, 2022
Merged
[hdf5] Refix msmpi library path in pkgconfig #25089
vicroms
merged 9 commits into
microsoft:master
from
JackBoosY:dev/jack/re-fix-hdf5-mpi-pkgconfig
Jun 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
labels
Jun 6, 2022
cc @dg0yt for review this PR. |
…jack/re-fix-hdf5-mpi-pkgconfig
LilyWangLL
approved these changes
Jun 7, 2022
dg0yt
suggested changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting a change to avoid giving a bad example for other ports.
Thomas1664
reviewed
Jun 7, 2022
Thomas1664
reviewed
Jun 7, 2022
ras0219-msft
requested changes
Jun 8, 2022
…jack/re-fix-hdf5-mpi-pkgconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25036 just fix the build issue, but there is a pkgconfig issue remains:
That's because hdf5 exports the full msmpi path to hdf5.pc:
#17941 only fixed
ompi-c
on non-Windows.Related: #24740
Already tested this with
gdal[hdf5]:x64-windows-static
.