Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][air-ctl]add support uwp and dynamic library #25113

Merged
merged 29 commits into from
Jun 9, 2022
Merged

[vcpkg baseline][air-ctl]add support uwp and dynamic library #25113

merged 29 commits into from
Jun 9, 2022

Conversation

inie0722
Copy link
Contributor

@inie0722 inie0722 commented Jun 7, 2022 •
edited
Loading

Describe the pull request

  • What does your PR fix?

    add support uwp and dynamic library

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@inie0722 inie0722 closed this Jun 7, 2022
@inie0722 inie0722 reopened this Jun 7, 2022
@inie0722 inie0722 closed this Jun 7, 2022
@inie0722 inie0722 reopened this Jun 7, 2022
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 8, 2022
LilyWangLL
LilyWangLL requested changes Jun 8, 2022
View reviewed changes
ports/air-ctl/vcpkg.json Show resolved Hide resolved
@JackBoosY JackBoosY changed the title [air-ctl]add support uwp and dynamic library [vcpkg baseline][air-ctl]add support uwp and dynamic library Jun 8, 2022
@JackBoosY JackBoosY mentioned this pull request Jun 8, 2022
Merged
LilyWangLL
LilyWangLL requested changes Jun 9, 2022
View reviewed changes
ports/air-ctl/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 9, 2022
@LilyWangLL
Copy link
Contributor

@ras0219-msft @BillyONeal This PR is ready to merge now. Could you please merge this PR? This is a baseline issue.

Thomas1664
Thomas1664 reviewed Jun 9, 2022
View reviewed changes
versions/a-/air-ctl.json Outdated Show resolved Hide resolved
@ras0219-msft ras0219-msft merged commit 062f92c into microsoft:master Jun 9, 2022
@ras0219-msft
Copy link
Contributor

ras0219-msft commented Jun 9, 2022 •
edited
Loading

Thanks for the update!

Please consider not deleting or moving tags in the future. It's trivial to just bump the patch version for things like this (1.0.1) -- that's why they exist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas1664 Thomas1664 Thomas1664 left review comments

@dg0yt dg0yt dg0yt left review comments

@LilyWangLL LilyWangLL LilyWangLL approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@inie0722 @LilyWangLL @ras0219-msft @dg0yt @Thomas1664