Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shaderwriter] Update to version 2.3.0. #25132

Merged
merged 4 commits into from
Jun 10, 2022
Merged

[shaderwriter] Update to version 2.3.0. #25132

merged 4 commits into from
Jun 10, 2022

Conversation

DragonJoker
Copy link
Contributor

Describe the pull request

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@DragonJoker DragonJoker marked this pull request as ready for review June 8, 2022 01:40
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Jun 8, 2022
@JackBoosY
Copy link
Contributor

JackBoosY commented Jun 8, 2022

I found two issues in the genreated file list:
1.

shaderwriter:x64-linux:/share/shaderwriter/SdwCompilersConfig-debug.cmake
shaderwriter:x64-linux:/share/shaderwriter/SdwCompilersConfig-release.cmake
shaderwriter:x64-linux:/share/shaderwriter/SdwCompilersConfig.cmake

These cmake files should be installed into share/SdwCompilers.

shaderwriter:x64-windows:/bin/sdwCompilerGlsl.dll
shaderwriter:x64-windows:/bin/sdwCompilerHlsl.dll
shaderwriter:x64-windows:/bin/sdwCompilerSpirV.dll
shaderwriter:x64-windows:/bin/sdwShaderAST.dll
shaderwriter:x64-windows:/bin/sdwShaderWriter.dll
shaderwriter:x64-windows:/debug/bin/sdwCompilerGlsld.dll
shaderwriter:x64-windows:/debug/bin/sdwCompilerHlsld.dll
shaderwriter:x64-windows:/debug/bin/sdwCompilerSpirVd.dll
shaderwriter:x64-windows:/debug/bin/sdwShaderASTd.dll
shaderwriter:x64-windows:/debug/bin/sdwShaderWriterd.dll

There is no pdbs, please add vcpkg_copy_pdbs() after vcpkg_cmake_configure.

ports/shaderwriter/portfile.cmake Outdated Show resolved Hide resolved
@DragonJoker DragonJoker requested a review from JackBoosY June 8, 2022 10:47
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 10, 2022
@ras0219-msft ras0219-msft merged commit 29fa20c into microsoft:master Jun 10, 2022
@ras0219-msft
Copy link
Contributor

Thanks for the update!

@DragonJoker DragonJoker deleted the shaderwriter branch June 10, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[shaderwriter] update to 2.3.0.
4 participants