-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[buck-yeh-bux-sqlite] New port #25144
Conversation
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
port-version
is different with the version of the underlying library, due to you made a change to this port, so this shouls add port-version
. You can see doc about port-version
: https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/manifest-files.md#port-version
Co-authored-by: Cheney Wang <38240633+Cheney-W@users.noreply.github.com>
Co-authored-by: Cheney Wang <38240633+Cheney-W@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout a15782fee2dfe7c33190d6acfced51f78a316abc -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/buck-yeh-bux-mariadb-client.json b/versions/b-/buck-yeh-bux-mariadb-client.json
index 63b5fad2..32c052bd 100644
--- a/versions/b-/buck-yeh-bux-mariadb-client.json
+++ b/versions/b-/buck-yeh-bux-mariadb-client.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "f0ad91f620ffdc0ad8b2618c79f38aefa00accf4",
+ "version": "1.0.3",
+ "port-version": 1
+ },
{
"git-tree": "b4476bced29bc063c2d1456d93c29ec0513b15f3",
"version": "1.0.3",
diff --git a/versions/baseline.json b/versions/baseline.json
index d871bed3..414bd080 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1182,7 +1182,7 @@
},
"buck-yeh-bux-mariadb-client": {
"baseline": "1.0.3",
- "port-version": 0
+ "port-version": 1
},
"buck-yeh-bux-sqlite": {
"baseline": "1.0.1",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout a15782fee2dfe7c33190d6acfced51f78a316abc -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/buck-yeh-bux-mariadb-client.json b/versions/b-/buck-yeh-bux-mariadb-client.json
index 63b5fad2..32c052bd 100644
--- a/versions/b-/buck-yeh-bux-mariadb-client.json
+++ b/versions/b-/buck-yeh-bux-mariadb-client.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "f0ad91f620ffdc0ad8b2618c79f38aefa00accf4",
+ "version": "1.0.3",
+ "port-version": 1
+ },
{
"git-tree": "b4476bced29bc063c2d1456d93c29ec0513b15f3",
"version": "1.0.3",
diff --git a/versions/b-/buck-yeh-bux.json b/versions/b-/buck-yeh-bux.json
index 448489c3..a1fec18c 100644
--- a/versions/b-/buck-yeh-bux.json
+++ b/versions/b-/buck-yeh-bux.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "70c9bddf07b6b1bf2bed8f994f13d1d5703ed105",
+ "version": "1.6.5",
+ "port-version": 1
+ },
{
"git-tree": "c9f914f4d748c8213f093a8553d786fc838f02e8",
"version": "1.6.5",
diff --git a/versions/baseline.json b/versions/baseline.json
index d871bed3..bb445e38 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1178,11 +1178,11 @@
},
"buck-yeh-bux": {
"baseline": "1.6.5",
- "port-version": 0
+ "port-version": 1
},
"buck-yeh-bux-mariadb-client": {
"baseline": "1.0.3",
- "port-version": 0
+ "port-version": 1
},
"buck-yeh-bux-sqlite": {
"baseline": "1.0.1",
arm64_windows failed ? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This is another package with no indication of usage outside upstream. I also find it strange that upstream supports linux, but the port doesn't. |
|
Verified in my local VM, following ports installed successfully:
|
Thanks for the new library! |
The idea is to minimize boilerplate code when doing the same things using native SQLite API. Only recurring usages are wrapped into helper classes or plain functions. Mixed uses of this module and the native API are expected. Always prefer
bux::C_SQLite
,bux::C_SQLiteStmt
oversqlite3*
,sqlite3_stmt*
and you will be fine.What does your PR fix?
Nothing
Which triplets are supported/not supported? Have you updated the CI baseline?
Supported
Yes,
buck-yeh-bux-sqlite:x64-linux=fail
is inserted.Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/