Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[convectionkernels] Add port. #25148

Merged
merged 4 commits into from
Jun 9, 2022
Merged

[convectionkernels] Add port. #25148

merged 4 commits into from
Jun 9, 2022

Conversation

DragonJoker
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes [New Port Request] cvtt #25147

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, No.

  • Does your PR follow the maintainer guide?

    Hopefully yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@DragonJoker DragonJoker marked this pull request as ready for review June 8, 2022 18:57
@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 9, 2022
ports/cvtt/CMakeLists.txt Outdated Show resolved Hide resolved
ports/cvtt/CMakeLists.txt Outdated Show resolved Hide resolved
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 9, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes, then LGTM.

Thanks for the PR!

ports/cvtt/vcpkg.json Outdated Show resolved Hide resolved
ports/cvtt/CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for cvtt have changed but the version was not updated
version: 2022-06-08
old SHA: afc83bed7d74230dac216f39068be5f0fbba04a9
new SHA: 4674907ed9d68777b1d8f6dca126fab50173dc8b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@ras0219-msft ras0219-msft merged commit 58196ee into microsoft:master Jun 9, 2022
@ras0219-msft ras0219-msft changed the title [cvtt] Add port. [convectionkernels] Add port. Jun 9, 2022
@ras0219-msft
Copy link
Contributor

Thanks again!

@DragonJoker DragonJoker deleted the cvtt branch June 10, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] cvtt
3 participants