Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[physx] Add support for Mac on ARM. #25154

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Conversation

Hoikas
Copy link
Contributor

@Hoikas Hoikas commented Jun 9, 2022

This pull requests ports the patch from NVIDIAGameWorks/PhysX#569 to fix the physx port build for Mac on ARM (aka "Silicon"). Unfortunately, we cannot simply download the patch from the PR itself due to the PR patch conflicting with our own remove-werror.patch.

  • What does your PR fix?

    See above

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Add support for community triplet arm64-osx.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Hoikas and others added 2 commits June 8, 2022 21:08
Co-authored-by: Darryl Pogue <darryl@dpogue.ca>
Co-authored-by: Niklas Gray <niklas@ourmachinery.com>
@Hoikas
Copy link
Contributor Author

Hoikas commented Jun 9, 2022

CC @dpogue, @colincornaby

@Hoikas Hoikas changed the title [physx[ Add support for Mac on ARM. [physx] Add support for Mac on ARM. Jun 9, 2022
@LilyWangLL LilyWangLL added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. labels Jun 9, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 9, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I was able to greatly reduce the size of the werror patch while also fetching the PR diffs from GitHub.

I pushed my changes to a branch, could you please pull it into this PR?

git fetch https://github.com/ras0219-msft/vcpkg physx-mac-arm
git merge FETCH_HEAD

@LilyWangLL LilyWangLL removed the info:reviewed Pull Request changes follow basic guidelines label Jun 10, 2022
@Hoikas
Copy link
Contributor Author

Hoikas commented Jun 10, 2022

Pulled, thanks for the improvement

@LilyWangLL LilyWangLL requested a review from ras0219-msft June 13, 2022 02:18
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 13, 2022
@ras0219-msft ras0219-msft merged commit ac7992c into microsoft:master Jun 13, 2022
@Hoikas Hoikas deleted the physx-mac-arm branch December 16, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants