Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtmidi] Add new 'linux-alsa' feature #25156

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

gvnnz
Copy link
Contributor

@gvnnz gvnnz commented Jun 9, 2022

  • What does your PR fix?

Aims to fix #6993 on Linux, where RtMidi is always compiled in Dummy mode (i.e. unusable).

  • Which triplets are supported/not supported? Have you updated the CI baseline?

The change affects only the Linux triplet.

Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

@Cheney-W Cheney-W added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines labels Jun 10, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweak, then LGTM. Thanks for the PR!

ports/rtmidi/vcpkg.json Outdated Show resolved Hide resolved
ports/rtmidi/portfile.cmake Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for rtmidi have changed but the version was not updated
version: 5.0.0#2
old SHA: 96895ea171292713b852e2de6dced7a9248b962c
new SHA: fc5202e306fea0fc26855620ea4af85884ecd617
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for rtmidi have changed but the version was not updated
version: 5.0.0#2
old SHA: 96895ea171292713b852e2de6dced7a9248b962c
new SHA: 70873823ce910dcf80078a94f12191371523d84c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for rtmidi have changed but the version was not updated
version: 5.0.0#3
old SHA: 70873823ce910dcf80078a94f12191371523d84c
new SHA: 44e7652fa8245777f949bd4d58d32a604c4913f2
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@gvnnz gvnnz requested a review from ras0219-msft June 11, 2022 09:06
@ras0219-msft ras0219-msft merged commit b9e42cd into microsoft:master Jun 13, 2022
@ras0219-msft
Copy link
Contributor

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package RtMidi always compile to "Dummy Mode"
3 participants