-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rtmidi] Add new 'linux-alsa' feature #25156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small tweak, then LGTM. Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for rtmidi have changed but the version was not updated
version: 5.0.0#2
old SHA: 96895ea171292713b852e2de6dced7a9248b962c
new SHA: fc5202e306fea0fc26855620ea4af85884ecd617
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for rtmidi have changed but the version was not updated
version: 5.0.0#2
old SHA: 96895ea171292713b852e2de6dced7a9248b962c
new SHA: 70873823ce910dcf80078a94f12191371523d84c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for rtmidi have changed but the version was not updated
version: 5.0.0#3
old SHA: 70873823ce910dcf80078a94f12191371523d84c
new SHA: 44e7652fa8245777f949bd4d58d32a604c4913f2
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Thanks again! |
What does your PR fix?
Aims to fix #6993 on Linux, where RtMidi is always compiled in Dummy mode (i.e. unusable).
Which triplets are supported/not supported? Have you updated the CI baseline?
The change affects only the Linux triplet.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes.