[tiff] Fix libm as dependency for android #25159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ports/tiff/android-pc-libm.patch
Outdated
| list(APPEND tiff_libs_private_list "${CMath_LIBRARY}") | ||
| endif() | ||
|
|
||
| +include(CheckLibraryExists) |
There was a problem hiding this comment.
Could this be done more cleanly in the FindCMath.cmake file? That's the part that's supposed to be doing this work.
There was a problem hiding this comment.
This sounds right. I have adjusted the patch to be isolated in FindCMath.cmake.
LilyWangLL
added
category:port-bug
LilyWangLL
changed the title
LilyWangLL
approved these changes
Jun 10, 2022
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes
-lmis missing as dependency on AndroidWhich triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
YesIf you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Followup #22137 and #24986
Upstream pull request: https://gitlab.com/libtiff/libtiff/-/merge_requests/350