Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipewire] new port #25160

Merged
merged 1 commit into from
Jun 13, 2022
Merged

[pipewire] new port #25160

merged 1 commit into from
Jun 13, 2022

Conversation

abique
Copy link
Contributor

@abique abique commented Jun 9, 2022

Hi,
This PR adds support to build pipewire client libraries on Linux.
Regards,
Alex

@abique abique changed the title Pipewire [pipewire] new port Jun 9, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for pipewire have changed but the version was not updated
version: 0.3.52
old SHA: 3be33b179df28d3a8a5e6538f7f21a58ee6c340d
new SHA: 7de7190a251710b6e65c3ad5d7061ba2d9c5e44b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@abique abique changed the title [pipewire] new port [meson,pipewire] new port and update meson to 0.62.2 Jun 9, 2022
@JackBoosY
Copy link
Contributor

Maybe you also need to take a look at port vcpkg-tool-meson?

@JackBoosY JackBoosY added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Jun 10, 2022
@abique
Copy link
Contributor Author

abique commented Jun 10, 2022

Maybe you also need to take a look at port vcpkg-tool-meson?

What do you mean?
This seems to be a way to install meson, but vcpkg isn't using this port to fetch meson right?

@abique
Copy link
Contributor Author

abique commented Jun 10, 2022

Ah you want me to also update the meson port?

@abique
Copy link
Contributor Author

abique commented Jun 10, 2022

@JackBoosY done.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for pipewire have changed but the version was not updated
version: 0.3.52
old SHA: 2d41c0388ed9d6fd4fc45ef7f832cb75e8695358
new SHA: 4df9c5a7cc620a7cdb608603c4df21d673c019d8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@dg0yt
Copy link
Contributor

dg0yt commented Jun 10, 2022

Changes to vcpkg_find_acquire_program trigger many expensive rebuilds. Do we need the meson update in vcpkg_find_acquire_program, or is it enough to make pipewire host-depend on vcpkg-tool-meson? I think this was the intention of port vcpkg-tool-meson.

@abique
Copy link
Contributor Author

abique commented Jun 10, 2022

I don't have enough knowledge here, all I can say is that the version of meson found in vcpkg_find_acquire_program was too old for pipewire.

Let me know what to do.

@Neumann-A
Copy link
Contributor

according to pipewire/pipewire version 0.59 should be enough.

Also please remove the changes to vcpkg_find_acquire_program they are not necessary. (I dont mind the update to vcpkg-tool-meson)

@abique
Copy link
Contributor Author

abique commented Jun 10, 2022

according to pipewire/pipewire version 0.59 should be enough.

Also please remove the changes to vcpkg_find_acquire_program they are not necessary. (I dont mind the update to vcpkg-tool-meson)

That's not my experience, when I've built pipewire, I definitely needed to update meson.

@dg0yt
Copy link
Contributor

dg0yt commented Jun 10, 2022

Let me know what to do.

  • Remove the changes from vcpkg_find_acquire_program, AND
  • add a host-dependency on vcpkg-tool-meson to pipewire

and see if it works.

@abique
Copy link
Contributor Author

abique commented Jun 10, 2022

Is vcpkg_find_acquire_program deprecated? I don't understand why there are two ways to acquire meson.

@Neumann-A
Copy link
Contributor

Is vcpkg_find_acquire_program deprecated? I don't understand why there are two ways to acquire meson.Is

For meson yes. You just need the host dependency on vcpkg-tool-meson

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-tool-meson have changed but the version was not updated
version: 0.62.2
old SHA: 347ff7efa6f9971fece17845c86c162b415be492
new SHA: 3479d54d4bc59d0f2b8f98f2dca3edb083582758
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@abique abique changed the title [meson,pipewire] new port and update meson to 0.62.2 [pipewire] new port Jun 10, 2022
@abique
Copy link
Contributor Author

abique commented Jun 10, 2022

I removed the meson update as it is not needed if I add the host dependency to meson.

@abique abique requested a review from JackBoosY June 10, 2022 12:44
@JackBoosY JackBoosY removed the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jun 13, 2022
ports/pipewire/portfile.cmake Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for pipewire have changed but the version was not updated
version: 0.3.52
old SHA: 52a865b11cd70f085cc902d5fce8974d062e3e48
new SHA: 4ec746fd8458f073339bf953335742b2abb0ac53
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

This patch only add support to build the client libraries.
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 13, 2022
@ras0219-msft ras0219-msft merged commit b88cd52 into microsoft:master Jun 13, 2022
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR!

@abique abique deleted the pipewire branch November 15, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants