Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mqtt-cpp] Update to 13.0.0 #25162

Merged
merged 8 commits into from
Jun 14, 2022
Merged

[mqtt-cpp] Update to 13.0.0 #25162

merged 8 commits into from
Jun 14, 2022

Conversation

dempo93
Copy link
Contributor

@dempo93 dempo93 commented Jun 9, 2022

Update mqtt-cpp to version 13.0.0

  • What does your PR fix?

Updates mqtt-cpp to version 13.0.0
Fix find_package by installing the main target into an appropriate directory
Specify std-features flags

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Tested x64-windows and x64-linux

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@ghost
Copy link

ghost commented Jun 9, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@dempo93 dempo93 mentioned this pull request Jun 9, 2022
Closed
Tradias
Tradias reviewed Jun 9, 2022
View reviewed changes
ports/mqtt-cpp/portfile.cmake Outdated Show resolved Hide resolved
ports/mqtt-cpp/portfile.cmake Outdated Show resolved Hide resolved
ports/mqtt-cpp/portfile.cmake Show resolved Hide resolved
ports/mqtt-cpp/vcpkg.json Outdated Show resolved Hide resolved
versions/m-/mqtt-cpp.json Outdated Show resolved Hide resolved
ports/mqtt-cpp/vcpkg.json Show resolved Hide resolved
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 10, 2022
FrankXie05
FrankXie05 requested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@FrankXie05 FrankXie05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be more standard.

ports/mqtt-cpp/portfile.cmake Outdated Show resolved Hide resolved
ports/mqtt-cpp/portfile.cmake Outdated Show resolved Hide resolved
ports/mqtt-cpp/portfile.cmake Outdated Show resolved Hide resolved
dempo93 and others added 3 commits June 13, 2022 16:23
@dempo93 @FrankXie05
Update ports/mqtt-cpp/portfile.cmake
18df26c 
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
@dempo93 @FrankXie05
Update ports/mqtt-cpp/portfile.cmake
6f8983b 
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
@dempo93 @FrankXie05
Update ports/mqtt-cpp/portfile.cmake
670f390 
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
@dempo93 dempo93 requested a review from FrankXie05 June 13, 2022 17:32
@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 14, 2022
@ras0219-msft ras0219-msft merged commit bcf3392 into microsoft:master Jun 14, 2022
@ras0219-msft
Copy link
Contributor

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@Tradias Tradias Tradias left review comments

@FrankXie05 FrankXie05 FrankXie05 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dempo93 @ras0219-msft @Tradias @dg0yt @FrankXie05