Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gdal] Fix building for 32bit Android and msvc with poppler #25190

Merged
merged 3 commits into from
Jun 15, 2022
Merged

[gdal] Fix building for 32bit Android and msvc with poppler #25190

merged 3 commits into from
Jun 15, 2022

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Jun 11, 2022 •
edited
Loading

Describe the pull request

  • What does your PR fix?

    Fixes
    • building gdal for 32 bit android
    • building with poppler with msvc

Error:

File API does not seem to support 64-bit offset.
If you still want to build GDAL without > 4GB file support,
add the -DBUILD_WITHOUT_64BIT_OFFSET define

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@m-kuhn m-kuhn force-pushed the gdal_32_bit_android branch from 3de762a to c3fe474 Compare June 12, 2022 17:45
@m-kuhn m-kuhn changed the title [gdal] Fix building for 32bit Android [gdal] Fix building for 32bit Android and windows with poppler Jun 12, 2022
@m-kuhn
Copy link
Contributor Author

m-kuhn commented Jun 12, 2022 •
edited
Loading

Integrated a patch regarding msvc/poppler from #25196 too to avoid merge conflicts.

@m-kuhn m-kuhn changed the title [gdal] Fix building for 32bit Android and windows with poppler [gdal] Fix building for 32bit Android and msvc with poppler Jun 12, 2022
@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Jun 13, 2022
@vicroms vicroms merged commit d2f3f30 into microsoft:master Jun 15, 2022
@m-kuhn m-kuhn deleted the gdal_32_bit_android branch June 15, 2022 19:57
@m-kuhn m-kuhn mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-kuhn @vicroms @Cheney-W