Skip to content

[check] Fix the incorrect path of dll #25211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jun 13, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:

  • ports/check/vcpkg.json (has deprecated license LGPL-2.1)

Deprecated and non deprecated license identifiers can be found here

@LilyWangLL LilyWangLL marked this pull request as ready for review June 13, 2022 09:57
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 13, 2022
@ras0219-msft ras0219-msft merged commit 73d50c1 into microsoft:master Jun 13, 2022
@ras0219-msft
Copy link
Collaborator

LGTM, thanks!

@Cheney-W Cheney-W deleted the Dev/Cheney/check branch August 30, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[check] checkShared produce broken binaries
3 participants