Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buck-yeh-bux] Update to 1.6.6 #25254

Merged
merged 87 commits into from
Jun 16, 2022
Merged

[buck-yeh-bux] Update to 1.6.6 #25254

merged 87 commits into from
Jun 16, 2022

Conversation

buck-yeh
Copy link
Contributor

  1. [New] C_UnicodeIn::encoding()
  2. [Change] Pass std::basic_string_view<T> arguments by value, not by reference, to ctor of bux::C_MBCStr
  3. [Change] Rehaul bux::fittestType() in C++20 - concept lite & if constexpr
  4. [Change] Add code page 951 (Big5 with HKSCS-2001) as one of encoding candidates to test in bux::C_UnicodeIn
  5. [Change] Forbid r-value string instance as ctor parameter of bux::C_IMemStreamT<>
  • What does your PR fix?

    Nothing

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Supported

    • x64-windows
    • x64-windows-static
    • x64-windows-static-md
    • x86-windows
    • x86-windows-static
    • x86-windows-static-md

    No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

buck-yeh and others added 30 commits August 18, 2021 03:35
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/buck-yeh-bux/vcpkg.json b/ports/buck-yeh-bux/vcpkg.json
index be582976..90210c0b 100644
--- a/ports/buck-yeh-bux/vcpkg.json
+++ b/ports/buck-yeh-bux/vcpkg.json
@@ -1,7 +1,6 @@
 {
   "name": "buck-yeh-bux",
   "version": "1.6.6",
-  "port-version": 0,
   "description": "A supplemental C++ library with functionalities not directly supported from Modern C++ standard.",
   "homepage": "https://github.com/buck-yeh/bux",
   "license": "MIT",
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for buck-yeh-bux have changed but the version was not updated
version: 1.6.6
old SHA: 7677cfc7f29c2994f89fbaa91486f8bf9e479d10
new SHA: 3d58f00b46ad32a1bfba6e5ee139aa47047e2bb6
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for buck-yeh-bux have changed but the version was not updated
version: 1.6.6
old SHA: 7677cfc7f29c2994f89fbaa91486f8bf9e479d10
new SHA: 3d58f00b46ad32a1bfba6e5ee139aa47047e2bb6
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 16, 2022
@FrankXie05
Copy link
Contributor

@buck-yeh Is this PR ready to merge?

@buck-yeh
Copy link
Contributor Author

buck-yeh commented Jun 16, 2022 via email

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jun 16, 2022
@dan-shaw dan-shaw merged commit dc6f878 into microsoft:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants