Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][chmlib] Fix the failed in baseline #25357

Merged
merged 1 commit into from
Jun 21, 2022
Merged

[vcpkg baseline][chmlib] Fix the failed in baseline #25357

merged 1 commit into from
Jun 21, 2022

Conversation

JonLiu1993
Copy link
Member

@JonLiu1993 JonLiu1993 commented Jun 21, 2022 •
edited
Loading

chmlib in ci.baseline.txt was removed by PR #22831, but this regression was wrongly introduced by PR #23732.
So remove the following codes from ci.baseline.txt fix the baseline regression.

chmlib:arm-uwp=fail
chmlib:x64-uwp=fail

The regression error message:

##[error]REGRESSIONS:
PASSING, REMOVE FROM FAIL LIST: chmlib:x64-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt).
##[error]REGRESSIONS:
PASSING, REMOVE FROM FAIL LIST: chmlib:arm-uwp (C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt).

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jun 21, 2022
@JonLiu1993 JonLiu1993 marked this pull request as ready for review June 21, 2022 05:44
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 21, 2022
@dan-shaw dan-shaw merged commit 0016cd5 into microsoft:master Jun 21, 2022
@JonLiu1993 JonLiu1993 deleted the dev/Jon/baseline branch June 22, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonLiu1993 @dan-shaw @LilyWangLL