[wxwidgets] Add feature wxdebug-level #25551
Conversation
Adela0814
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
IMO the current state of this PR is invalid:
The activation of feature wxdebug-level removes API. This is not allowed in vcpkg: Downstream ports could no longer express their dependency.
If anything, the default debug level (1) can be tied to a default feature.
And the debug level 0 should be burned into the headers in a way that downstream ports follow the wxwidgets ports configuration.
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/vcpkg-ci-wxwidgets/vcpkg.json
Valid values for the license field can be found in the documentation
| OPTIONS_RELEASE | ||
| -DwxBUILD_DEBUG_LEVEL=0 | ||
| OPTIONS | ||
| ${FEATURE_OPTIONS} |
There was a problem hiding this comment.
I assume, this still should be an OPTIONS_RELEASE because in general it's nice to have wxBUILD_DEBUG_LEVEL=1 when building in Debug mode
| OPTIONS | ||
| ${FEATURE_OPTIONS} |
There was a problem hiding this comment.
| OPTIONS | |
| ${FEATURE_OPTIONS} | |
| OPTIONS_RELEASE | |
| -DwxBUILD_DEBUG_LEVEL=0 | |
| OPTIONS_DEBUG | |
| -DwxBUILD_DEBUG_LEVEL=1 |
There was a problem hiding this comment.
I'm afraid, this will not solve the original issue described here: #25437
|
Duplicate of #25572 |
There was a problem hiding this comment.
It is still the wrong approach. If one downstream port requests wxwidgets[wxdebug-level-0], it will remove behaviours for other downstream ports.
"Features must be treated as additive functionality."
Wxwidget's debug support is a set of behaviours which are enabled by the recommended default level 1.
So the natural representation for level 1 is a default feature in vcpkg.
Cf. "Default features should enable behaviors, not APIs"
|
@dg0yt, since this is closed, do you have an idea how to implement this feature in a correct way? |
I outlined this already twice in this PR: There must be default feature to control (i.e. enable )wxwidgets default debugging support. |
Fix #25437
Changed the option to port feature.