Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][tmx] Fix libxml dependency #25616

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 7, 2022

github-actions[bot]
github-actions bot previously approved these changes Jul 7, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/tmx/vcpkg.json

Valid values for the license field can be found in the documentation

@JackBoosY JackBoosY self-assigned this Jul 7, 2022
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jul 7, 2022
@JackBoosY JackBoosY changed the title [tmx] Fix libxml dependency [vcpkg baseline][tmx] Fix libxml dependency Jul 7, 2022
@JackBoosY
Copy link
Contributor

JackBoosY commented Jul 7, 2022

Is versions/baseline.txt file format changed?
I noticed there is 100755 → 100644.

@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 7, 2022

Is versions/baseline.txt file format changed? I noticed there is 100755 → 100644.

Isn't this the UNIX file permissions, with the executable bit correctly removed from this plain file?
I didn't do any other step than usual (git, vcpkg x-add-version). But there was a manual edit recently, with an extra line break added.

@JackBoosY
Copy link
Contributor

Isn't this the UNIX file permissions, with the executable bit correctly removed from this plain file? I didn't do any other step than usual (git, vcpkg x-add-version). But there was a manual edit recently, with an extra line break added.

Can you please rerun ./vcpkg x-add-version --overwrite-version --all?

@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 7, 2022

Isn't this the UNIX file permissions, with the executable bit correctly removed from this plain file? I didn't do any other step than usual (git, vcpkg x-add-version). But there was a manual edit recently, with an extra line break added.

Can you please rerun ./vcpkg x-add-version --overwrite-version --all?

No changes.

@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 7, 2022

@JackBoosY
Copy link
Contributor

Well, okay.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 7, 2022
@vicroms vicroms merged commit cf287a6 into microsoft:master Jul 7, 2022
@dg0yt dg0yt deleted the libxml2-tmx branch July 7, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants