[python3] x64-linux-dynamic fixes #25995
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Osyotr
changed the title
Osyotr
force-pushed
the
py3_linux_dynamic
branch
from
06db03e
to
5216ebf
Compare
Adela0814
added
the
category:port-bug
Adela0814
added
requires:author-response
and removed
info:reviewed
Osyotr
dismissed stale reviews from Adela0814 and github-actions[bot]
via
54b5f1a
|
@Hoikas is it worth adding |
|
I'm not sure how widely the limited API library is used, TBH. If you have a use for it or it's trivial to make available, I think it would be a good thing to have as an option. |
|
It's already available but with the cost of |
|
@Adela0814 maybe |
Adela0814
added
info:reviewed
ports/python3/portfile.cmake
Outdated
| @@ -204,6 +205,11 @@ if(VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP) | |||
| endif() | |||
| endif() | |||
| else() | |||
| # Python Stable ABI is incompatible with --with-pydebug option | |||
There was a problem hiding this comment.
vcpkg does not provide a stable ABI for installed trees, so I'm not sure why this is a relevant distinction? Note that vcpkg's python almost never matches the system python.
There was a problem hiding this comment.
This is what their buildsystem does.
Upon further investigation, I found out that debug builds are now abi compatible with release builds python/cpython#12615
Maybe ask maintainers whether this is something they forgot to address in their buildsystem?
BillyONeal
added
requires:author-response
and removed
info:reviewed
|
@BillyONeal the additional binary is |
Ah, I see. "Python Stable ABI" isn't a statement about the shipping Python bits, it's the name of a specific binary. |
BillyONeal
dismissed stale reviews from Adela0814 and github-actions[bot]
via
aa13372
BillyONeal
added
info:reviewed
|
Thanks! |
| self.add(Extension('readline', ['readline.c'], | ||
| library_dirs=['/usr/lib/termcap'], | ||
| extra_link_args=readline_extra_link_args, | ||
| + runtime_library_dirs=self.lib_dirs, |
There was a problem hiding this comment.
Apart from using absolute paths, this patch broke the static build. The build ends successful, but it lacks important components such as binascii. The error logs lists unknown -R... parameters.
There was a problem hiding this comment.
Use of absolute paths is ok at build time. They will be fixed when installing.
I'll try to get rid of this patch later today and disable python's check for whether module loads or not.
This PR fixes build issues with
x64-linux-dynamictriplet.setup.pyto force rpath flags for extensions.VCPKG_POLICY_MISMATCHED_NUMBER_OF_BINARIESbecause there's an additional binary in release builds (see comment in portfile).libuuiddependencyFor #25668