Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quoting for the
EXAMPLES.md
file :Eigen is known as:
FindEigen3.cmake
andEigen3Config.cmake
distributed by the project).libeigen3-dev
in Debian-based systems.eigen3
in FreeBSD [1]eigen3
in MacPorts [2]eigen
in homebrew [3]eigen3
in fedora [4]eigen
in Gentoo [5]eigen3
in MINGW [6]Given that (except for homebrew and gentoo's portage) the Eigen package is always called
eigen3
, it could make sense to call iteigen3
also invcpkg
?[1] : https://svnweb.freebsd.org/ports/head/math/eigen3/
[2] : https://trac.macports.org/browser/trunk/dports/math/eigen3/Portfile
[3] : http://brewformulas.org/Eigen
[4] : http://rpms.famillecollet.com/rpmphp/zoom.php?rpm=eigen3
[5] : https://packages.gentoo.org/packages/dev-cpp/eigen
[6] : https://github.com/msys2/MINGW-packages/tree/44faea9dde7642988ed6e837d6a39d8effaea3f4/mingw-w64-eigen3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should definitely be renamed to eigen3! Great detective work.