[OSG] new attempt to preserve ARGS #27967
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if(DEFINED ARGS) | ||
| set(z_vcpkg_find_package_${z_vcpkg_find_package_backup_id}_backup_ARGS "${ARGS}") | ||
| set(z_vcpkg_find_package_${z_vcpkg_find_package_package_name}_backup_ARGS "${ARGS}") |
There was a problem hiding this comment.
I didn't use package_name due to nesting of calls to the same package. E.g. different parts of a nested calls looking up something very common like zlib on different levels. Having a unique id is the only save way to avoid overwriting previous values.
There was a problem hiding this comment.
nesting of calls to the same package. E.g. different parts of a nested calls looking up something very common like zlib on different levels
But this would require ZLIB to cyclically request ZLIB again, right? Not just A -> B -> ZLIB + A -> C -> ZLIB.
Though now that you mention it, ZLIB (MODULE) could chain-find ZLIB (CONFIG), so we would need to distinguish those cases :(
There was a problem hiding this comment.
find_package(ZLIB NO_DEFAULT_PATH PATHS <somecustompath>) [<- custom module or config] which then calls the original find_package(ZLIB).
There was a problem hiding this comment.
FTR the CURL find module calls CURL config.
|
consider waiting if the issue is still present with #27939 merged. |
MonicaLiu0311
added
the
category:tool-update
Attempts to fix osg build fail on https://dev.azure.com/vcpkg/public/_build/results?buildId=81160&view=results.
Issue: find_package(${ARGS}) fails because ARGS is empty.
Stacking find_package calls within the macro results in ARGS being unset.
Tagging @Neumann-A for review to ensure this still fixes #27498 and #19030