[angle] Improve UX for unofficial CMake package #28547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlyanon
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/angle/vcpkg.json
Valid values for the license field can be found in the documentation
friendlyanon
force-pushed
the
port/angle
branch
from
6f0e9b7 to
8d17e19
Compare
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/angle/vcpkg.json
Valid values for the license field can be found in the documentation
JonLiu1993
added
the
category:port-feature
|
@friendlyanon, Thanks for your pr, please add |
friendlyanon
force-pushed
the
port/angle
branch
from
8d17e19 to
bc4031d
Compare
Only the unofficial::angle::libGLESv2 and unofficial::angle::libEGL targets are meant to be used, because they are the targets that no other depends on.
friendlyanon
changed the title
JonLiu1993
approved these changes
Dec 27, 2022
JonLiu1993
added
requires:all-feature-testing
|
Test usage succeeds with angle:x64-windows triplet. |
JonLiu1993
added
info:reviewed
past-due
added a commit
to past-due/vcpkg
that referenced
this pull request
Jan 27, 2023
JavierMatosD
pushed a commit
that referenced
this pull request
Feb 10, 2023
…ates) (#27444) * [angle] Update to chromium/5249 - Refactor build system based on WebKit's CMake build system for libANGLE - Add maintainer-notes.md * [angle] Fetch & generate more files in portfile * [angle] Move maintainer-notes.md * [angle] Port changes from #27701 * Merge install tweak from #28547 * [angle] Tweak PlatformLinux * Run x-add-version * [angle] Update to chromium/5414 * Run x-add-version * Fix version database. * Fix version database --------- Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com> Co-authored-by: Jonliu1993 <13720414433@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config script to the unofficial CMake package that properly propagates transitive dependencies and usage info for the unofficial CMake package to avoid vcpkg barfing almost all the targets in it.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes