Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg - fix spirv-tools static #29976

Closed
wants to merge 1 commit into from
Closed

vcpkg - fix spirv-tools static #29976

wants to merge 1 commit into from

Conversation

fran6co
Copy link
Contributor

@fran6co fran6co commented Mar 2, 2023

spriv-tools build shared and static no matter what linkage is selected and the find script will complain that the dll is not there when building on static

@fran6co
Copy link
Contributor Author

fran6co commented Mar 2, 2023

Vcpkg doesn't allow for this, I will figure out some other way

@fran6co fran6co closed this Mar 2, 2023
@fran6co fran6co deleted the fix_spriv_dll branch March 2, 2023 20:20
@dg0yt
Copy link
Contributor

dg0yt commented Mar 3, 2023

It seems the problem wasn't your PR, but the PR uncovered a port problem.

-- Performing post-build validation
warning: DLLs should not be present in a static build, but the following DLLs were found:

    D:\packages\spirv-tools_x64-windows-static\debug\bin\SPIRV-Tools-shared.dll
    D:\packages\spirv-tools_x64-windows-static\bin\SPIRV-Tools-shared.dll

@fran6co
Copy link
Contributor Author

fran6co commented Mar 3, 2023

I think one possible solution is changing the cmake so it builds one or the other

@dg0yt
Copy link
Contributor

dg0yt commented Mar 3, 2023

Yes. Many ports carry patches for this purposes.

@dg0yt
Copy link
Contributor

dg0yt commented Mar 4, 2023

I'm not sure if it can be fixed within the vcpkg port scope. This package seems to need action both upstream and downstream:
KhronosGroup/SPIRV-Tools#3909

@fran6co
Copy link
Contributor Author

fran6co commented Mar 4, 2023

From the comments on that issue it looks like it will not be fixed upstream anytime soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fran6co @dg0yt