[vcpkg scripts] Remove deprecate functions vcpkg_*_cmake and vcpkg_fixup_cmake_targets

[JackBoosY]

Remove these deprecated functions completely since no port uses them.

[JackBoosY]

Depends on #29882 and #29883.

[dg0yt]

You cannot remove the function names. User ports may depend on them, and in manifest mode, even vcpkg ports will need them forever.

[JackBoosY]

You cannot remove the function names. User ports may depend on them, and in manifest mode, even vcpkg ports will need them forever.

Good point.
However, there is no way to call vcpkg_cmake_* / vcpkg_cmake_config_fixup in those functions.
These functions are just a burden for vcpkg.

[dg0yt]

Yes, it is technical debt which cannot be removed (except for a major release of vcpkg).
Fortunately, the new GH checks should ensure that these functions are not used in new ports.

[JackBoosY]

At least we need a point in time to notify the user that they are about to be removed, like normal 3rd party libraries do.
Let's see what the maintainer team thinks.

[Neumann-A]

You cannot remove the scripts due to versioning?

[JackBoosY]

You cannot remove the scripts due to versioning?

Wouldn't versioning affect these scripts?

[dg0yt]

You cannot remove the scripts due to versioning?

These are the unversioned global scripts. Manifest mode allows to install old port versions which rely on these scripts.
There is more such legacy stuff, like some find_package particularities in vcpkg.cmake which cannot be remove despite better wrappers in current port versions.

[Neumann-A]

I mean we could remove them if vcpkg-tool adds an implicit dep to a vcpkg-script port but that comes with its own set of advantages and disadvantages

[BillyONeal]

I agree with @dg0yt .

[JackBoosY]

Okay, so we need to modify our GitHub actions to report error when PR changes contains those deprecated functions right?

[dg0yt]

Maybe upgrade selected keywords from warning to error.

vcpkg/.github/workflows/untrustedPR.yml

Line 30 in 02ad673

if [ -s .github-pr.changed-portfiles ]; then (grep -n -H -E '(vcpkg_apply_patches|vcpkg_build_msbuild|vcpkg_extract_source_archive_ex|vcpkg_install_cmake|vcpkg_build_cmake|vcpkg_configure_cmake|vcpkg_fixup_cmake_targets)' $(cat .github-pr.changed-portfiles) || true) > .github-pr.deprecated-cmake; else touch .github-pr.deprecated-cmake; fi

[JackBoosY]

Close this PR since it's not appropriate.

[dg0yt]

You could also issue a warning at the top of each deprecated function.

[JackBoosY]

You could also issue a warning at the top of each deprecated function.

Will do.