[LIBMYSQL] Fix osx build creates invalid nuget package #31134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GordonSmith
force-pushed
the
MYSQL_OSX_NUGET
branch
from
c9d6d67 to
10fbd89
Compare
GordonSmith
force-pushed
the
MYSQL_OSX_NUGET
branch
3 times, most recently
from
348e727 to
afb58ef
Compare
dg0yt
reviewed
Apr 26, 2023
ports/libmysql/portfile.cmake
Outdated
Comment on lines
130
to
131
| "${CURRENT_PACKAGES_DIR}/lib/plugin" | ||
| "${CURRENT_PACKAGES_DIR}/lib/plugin/debug" | ||
| "${CURRENT_PACKAGES_DIR}/debug/lib/plugin" |
There was a problem hiding this comment.
Given that lib/plugin is removed before lib/plugin/debug, the second line is pointless - I guess it was meant to do what is the new debug/lib/plugin line now.
There was a problem hiding this comment.
Oh, and there is also lib/debug - is this really created?
There was a problem hiding this comment.
Looks like lib/debug is needed, I removed the lib/plugin/debug line.
FrankXie05
added
the
category:port-update
GordonSmith
force-pushed
the
MYSQL_OSX_NUGET
branch
6 times, most recently
from
b149dae to
19cc137
Compare
Fix: Change /lib/plugin/debug to /debug/lib/plugin Feat: Change ref to actual tagged version Fix: Remove duplicate "remove" file Fix: Add WITH_BUILD_ID to MAYBE_UNUSED_VARIABLES Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
force-pushed
the
MYSQL_OSX_NUGET
branch
from
19cc137 to
934d295
Compare
autoantwort
reviewed
May 4, 2023
| REF 1bfe02bdad6604d54913c62614bde57a055c8332 # 8.0.32 | ||
| SHA512 9a556b783ee978c919ccc0c1c99ab4a84ecc9fe0b75e2e100ad616f3b7c7bd280c8da63eb9e9c98291256ebbd130aef8c6e5c404e93b7cc8b8fe754b055b650f | ||
| REF mysql-${VERSION} | ||
| SHA512 1233abe4fe055f62cc28c847e77bcfc37e03e77ee68b8606e5ad722e0b6d1ae30b95bbe623a88cecdfa0b5868b61eabaf4b99e78cb6fbb9cf3627c91d17feb0e |
There was a problem hiding this comment.
The SHA512 is wrong. And why it is different if you are downloading the same release?
There was a problem hiding this comment.
Hm
➜ Downloads vcpkg hash mysql-server-1bfe02bdad6604d54913c62614bde57a055c8332.tar.gz
9a556b783ee978c919ccc0c1c99ab4a84ecc9fe0b75e2e100ad616f3b7c7bd280c8da63eb9e9c98291256ebbd130aef8c6e5c404e93b7cc8b8fe754b055b650f
➜ Downloads vcpkg hash mysql-server-mysql-8.0.32.tar.gz
8b9f15b301b158e6ffc99dd916b9062968d36f6bdd7b898636fa61badfbe68f7328d4a39fa3b8b3ebef180d3aec1aee353bd2dac9ef1594e5772291390e17ac0
There was a problem hiding this comment.
Bizarre - I can confirm this is wrong, not sure how it snuck through the PR tests.
I see you fixed already - thx.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of plugins references wrong debug folder. This causes the NuGet
package creation to fail on OSX.
Added removal of debug manuals
Tweaked reference to use actual version tag