[gsl] fix gsl x64-linux-dynamic build by guarding win32 string replaces

[sjperkins]

• Changes comply with the maintainer guide
• SHA512s are updated for each updated download
• The "supports" clause reflects platforms that may be fixed by this new version
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[sjperkins]

Related issues:

• [many ports] x64-linux-dynamic build failures #25668

Without this, x64-linux-dynamic fails on debug as follows:

• install-x64-linux-dynamic-dbg-err.log
• install-x64-linux-dynamic-dbg-out.log

[dg0yt]

You shouldn't completely remove burning GSL_DLL into the installed header.

[dg0yt]

... but this isn't.

[sjperkins]

Thanks for correcting, my cmake knowledge isn't extensive. The section looks like this now:

file(READ gsl_types.h GSLTYPES_H)
if(WIN32)
    if(BUILD_SHARED_LIBS)
        target_compile_definitions(gsl PRIVATE GSL_DLL)
    endif()
endif(WIN32)
file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/gsl_types.h "${GSLTYPES_H}")

[Osyotr]

Oh snap, I actually meant target_compile_definitions(gsl PRIVATE DLL_EXPORT)
@dg0yt is right, burning GSL_DLL into this header is still needed.

[sjperkins]

Oh snap, I actually meant target_compile_definitions(gsl PRIVATE DLL_EXPORT) @dg0yt is right, burning GSL_DLL into this header is still needed.

No problem. Have made the change locally. However, the CI seems to point out the following problem downstream with mathgl:

error: building vcpkg-ci-mathgl:x86-windows failed with: CASCADED_DUE_TO_MISSING_DEPENDENCIES
    due to the following missing dependencies:
        mathgl[arma]:x86-windows
        mathgl[core]:x86-windows
        mathgl[examples]:x86-windows
        mathgl[fltk]:x86-windows
        mathgl[gif]:x86-windows
        mathgl[glut]:x86-windows
        mathgl[gsl]:x86-windows
        mathgl[hdf5]:x86-windows
        mathgl[jpeg]:x86-windows
        mathgl[opengl]:x86-windows
        mathgl[png]:x86-windows
        mathgl[qt5]:x86-windows
        mathgl[wx]:x86-windows
        mathgl[zlib]:x86-windows

Can you give advice on how to resolve this? I guess it may be related to this

• [mathgl] Wrong GSL linakge #30029

[dg0yt]

It is really only one line which needs to changed or guarded.

[sjperkins]

CI is passing.

[JonLiu1993]

@sjperkins, thanks for the PR, please also change the vcpkg.json file "port-version" from 2 to 3.

[JonLiu1993]

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

[sjperkins]

Thanks for the merge