Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vulkan Headers to 1.3.250 #31721

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Update Vulkan Headers to 1.3.250 #31721

merged 2 commits into from
Jun 1, 2023

Conversation

juan-lunarg
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default installing vulkan-headers resulted in the following message:

vulkan-headers is header-only and can be used from CMake via:

    find_path(VULKAN_HEADERS_INCLUDE_DIRS "vk_video/vulkan_video_codec_h264std.h")
    target_include_directories(main PRIVATE ${VULKAN_HEADERS_INCLUDE_DIRS})

As a result I added this usage file with the proper find_package instructions based on the official instructions from the repo.

https://github.com/KhronosGroup/Vulkan-Headers/blob/main/BUILD.md

@FrankXie05 FrankXie05 self-assigned this May 31, 2023
ports/vulkan-headers/usage Outdated Show resolved Hide resolved
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label May 31, 2023
@FrankXie05
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

@FrankXie05 FrankXie05 marked this pull request as draft May 31, 2023 03:07
@juan-lunarg juan-lunarg marked this pull request as ready for review May 31, 2023 15:58
@juan-lunarg juan-lunarg requested a review from FrankXie05 May 31, 2023 15:59
@FrankXie05
Copy link
Contributor

The usage has been tested successfully locally.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jun 1, 2023
@dan-shaw dan-shaw merged commit 69f86f8 into microsoft:master Jun 1, 2023
@juan-lunarg juan-lunarg deleted the juan/vulkan_headers branch June 1, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants