Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[concurrencpp] Fix error C2039: 'numeric_limits': is not a member of 'std' #32121

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

Cheney-W
Copy link
Contributor

In an internal version of Visual Studio, concurrencpp install failed with following error:

D:\buildtrees\concurrencpp\src\v.0.1.6-2315a11616.clean\include\concurrencpp/executors/constants.h(11): error C2039: 'numeric_limits': is not a member of 'std'
D:\buildtrees\concurrencpp\src\v.0.1.6-2315a11616.clean\include\concurrencpp/executors/constants.h(11): error C2039: 'max': is not a member of '`global namespace''

This issue came from microsoft/STL#3721 and could be fixed by adding #include<limits>.
I have submitted an issue David-Haim/concurrencpp#137 to upstream.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jun 20, 2023
@Cheney-W Cheney-W marked this pull request as ready for review June 20, 2023 10:38
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 21, 2023
@vicroms vicroms merged commit 48f861d into microsoft:master Jun 22, 2023
@Cheney-W Cheney-W deleted the Dev/Cheney/20230620 branch June 25, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants