Skip to content

Comments

[vcpkg baseline][fastrtps] Use more precise version comparison#32257

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
Cheney-W:Dev/Cheney/fastrtps
Jun 27, 2023
Merged

[vcpkg baseline][fastrtps] Use more precise version comparison#32257
vicroms merged 1 commit intomicrosoft:masterfrom
Cheney-W:Dev/Cheney/fastrtps

Conversation

@Cheney-W
Copy link
Contributor

Fixed CI pipeline issue:

fastrtps:x86-windows
fastrtps:x64-windows
include\fastrtps/utils/TimedMutex.hpp(93): error C2664: 'int _Mtx_timedlock(_Mtx_t,const xtime *)': cannot convert argument 2 from '_timespec64 *' to 'const xtime *'

This issue is due to the compiler version of VS2022 17.6.3 being greater than the version condition we have set, resulting in the execution of new behaviors introduced by the patch. However, these new behaviors were actually intended for VS2022 17.7 preview 2 (internal modifications have already been released in this version).

To fix this issue, I am using the compiler version from VS2022 17.7 preview 2 as the condition for judgment.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jun 27, 2023
@Cheney-W Cheney-W marked this pull request as ready for review June 27, 2023 09:41
@vicroms vicroms merged commit 0d1150c into microsoft:master Jun 27, 2023
@dg0yt dg0yt mentioned this pull request Jun 27, 2023
7 tasks
@Cheney-W Cheney-W deleted the Dev/Cheney/fastrtps branch June 28, 2023 01:55
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants