scripts/msys => scripts/cmake #32375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "msys" directory looked like a "maintainer help" directory (like scripts/boost is) so it wasn't included in standalone distributions of vcpkg. It seems like the correct fix for this is just to move it into the scripts/cmake directory.
BillyONeal
added
category:vcpkg-bug
Neumann-A
reviewed
Jul 3, 2023
| @@ -283,7 +283,7 @@ macro(z_vcpkg_acquire_msys_declare_all_packages) | |||
| URL "https://mirror.msys2.org/msys/x86_64/automake1.16-1.16.5-1-any.pkg.tar.zst" | |||
| SHA512 62c9dfe28d6f1d60310f49319723862d29fc1a49f7be82513a4bf1e2187ecd4023086faf9914ddb6701c7c1e066ac852c0209db2c058f3865910035372a4840a | |||
| DEPS bash perl | |||
| PATCHES "${SCRIPTS}/msys/compile_wrapper_consider_clang-cl.patch" | |||
| PATCHES "${CMAKE_CURRENT_LIST_DIR}/compile_wrapper_consider_clang-cl.patch" | |||
There was a problem hiding this comment.
can this please be moved into a subfolder? to separate patches and scripts ?
There was a problem hiding this comment.
What do we gain by separating those?
There was a problem hiding this comment.
I'm going to merge as is for now but if there are many many patches in the future we can always move it again.
|
Issue: #31565 |
MonicaLiu0311
added
the
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "msys" directory looked like a "maintainer help" directory (like scripts/boost is) so it wasn't included in standalone distributions of vcpkg.
It seems like the correct fix for this is just to move it into the scripts/cmake directory.
Fixes: #31565