Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[curl] Add zstd feature. #32533

Merged
merged 2 commits into from
Jul 13, 2023
Merged

[curl] Add zstd feature. #32533

merged 2 commits into from
Jul 13, 2023

Conversation

teo-tsirpanis
Copy link
Contributor

Contributes to #32109.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

This was referenced Jul 12, 2023
Merged
Closed
@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 13, 2023
@Cheney-W
Copy link
Contributor

Feature passed with following triplets:
x86-windows
x64-windows
x64-windows-static

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jul 13, 2023
@BillyONeal BillyONeal merged commit 17fc556 into microsoft:master Jul 13, 2023
@BillyONeal
Copy link
Member

Thanks!

@teo-tsirpanis teo-tsirpanis deleted the curl-zstd branch July 13, 2023 18:26
ihnorton pushed a commit to TileDB-Inc/TileDB that referenced this pull request Jul 13, 2023
@teo-tsirpanis
Build curl with ZStandard support on vcpkg when serialization is enab…
4af3705 
…led. (#4166)

[SC-31595](https://app.shortcut.com/tiledb-inc/story/31595/enable-zstd-in-vcpkg-curl-build)

The vcpkg port for curl does not have a feature to enable zstd. I created one and opened microsoft/vcpkg#32533 to add it upstream.

---
TYPE: BUILD
DESC: Build curl with ZStandard support on vcpkg when serialization is enabled.
Shelnutt2 pushed a commit to TileDB-Inc/TileDB that referenced this pull request Jul 22, 2023
@teo-tsirpanis @Shelnutt2
Build curl with ZStandard support on vcpkg when serialization is enab…
29c9891 
…led. (#4166)

[SC-31595](https://app.shortcut.com/tiledb-inc/story/31595/enable-zstd-in-vcpkg-curl-build)

The vcpkg port for curl does not have a feature to enable zstd. I created one and opened microsoft/vcpkg#32533 to add it upstream.

---
TYPE: BUILD
DESC: Build curl with ZStandard support on vcpkg when serialization is enabled.
ihnorton pushed a commit to TileDB-Inc/TileDB that referenced this pull request Jul 22, 2023
@Shelnutt2 @teo-tsirpanis
Build curl with ZStandard support on vcpkg when serialization is enab…
69676e6 
…led. (#4166) (#4192)

[SC-31595](https://app.shortcut.com/tiledb-inc/story/31595/enable-zstd-in-vcpkg-curl-build)

The vcpkg port for curl does not have a feature to enable zstd. I created one and opened microsoft/vcpkg#32533 to add it upstream.

---
TYPE: BUILD
DESC: Build curl with ZStandard support on vcpkg when serialization is enabled.

Co-authored-by: Theodore Tsirpanis <theodore.tsirpanis@tiledb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teo-tsirpanis @Cheney-W @BillyONeal