Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cxxgraph] Add new port CXXGraph #32696

Merged
merged 12 commits into from
Jul 25, 2023
Merged

Conversation

QuantumFelidae
Copy link
Contributor

@QuantumFelidae QuantumFelidae commented Jul 21, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@QuantumFelidae
Copy link
Contributor Author

@microsoft-github-policy-service agree

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 24, 2023
ports/cxxgraph/portfile.cmake Outdated Show resolved Hide resolved
ports/cxxgraph/portfile.cmake Outdated Show resolved Hide resolved
ports/cxxgraph/vcpkg.json Show resolved Hide resolved
ports/cxxgraph/portfile.cmake Show resolved Hide resolved
@FrankXie05
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

@FrankXie05 FrankXie05 marked this pull request as draft July 24, 2023 06:26
@QuantumFelidae QuantumFelidae marked this pull request as ready for review July 24, 2023 23:27
@FrankXie05
Copy link
Contributor

The usage tested successfully on x64-windows.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jul 25, 2023
FrankXie05
FrankXie05 previously approved these changes Jul 25, 2023
@QuantumFelidae
Copy link
Contributor Author

The PR was not marked as draft, so consider this comment to be marking as ready for review :)

@BillyONeal BillyONeal merged commit 080bf4d into microsoft:master Jul 25, 2023
@BillyONeal
Copy link
Member

Looks great, thanks for the new port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants