-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[modern-cpp-kafka] New port #32903
[modern-cpp-kafka] New port #32903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this really needs a CMake project. You can just add a config file directly to the port and install from the portfile.
@dg0yt |
Usage passed on x64-osx with following demo code set(CMAKE_CXX_STANDARD 17)
find_package(unofficial-modern-cpp-kafka CONFIG REQUIRED)
add_executable(test_kafka main.cpp)
target_link_libraries(test_kafka PRIVATE unofficial::modern-cpp-kafka::modern-cpp-kafka) #include "kafka/AdminClient.h"
#include "kafka/Error.h"
int main() {
kafka::Properties props;
kafka::clients::admin::AdminClient client(props);
return 0;
} |
The usage test passed on
|
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.Close #32897