Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modern-cpp-kafka] New port #32903

Merged
merged 6 commits into from
Aug 3, 2023

Conversation

xiaozhuai
Copy link
Contributor

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Close #32897

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this really needs a CMake project. You can just add a config file directly to the port and install from the portfile.

ports/modern-cpp-kafka/CMakeLists.txt Outdated Show resolved Hide resolved
@xiaozhuai
Copy link
Contributor Author

xiaozhuai commented Aug 2, 2023

I don't think this really needs a CMake project. You can just add a config file directly to the port and install from the portfile.

@dg0yt
I know. But I prefer to provide a CMakeLists.

@xiaozhuai
Copy link
Contributor Author

Usage passed on x64-osx with following demo code

set(CMAKE_CXX_STANDARD 17)

find_package(unofficial-modern-cpp-kafka CONFIG REQUIRED)
add_executable(test_kafka main.cpp)
target_link_libraries(test_kafka PRIVATE unofficial::modern-cpp-kafka::modern-cpp-kafka)
#include "kafka/AdminClient.h"
#include "kafka/Error.h"

int main() {
    kafka::Properties props;
    kafka::clients::admin::AdminClient client(props);
    return 0;
}

@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 3, 2023
@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows (header files found):

modern-cpp-kafka provides CMake targets:

    find_package(unofficial-modern-cpp-kafka CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::modern-cpp-kafka::modern-cpp-kafka)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Aug 3, 2023
@JavierMatosD JavierMatosD merged commit 4345d72 into microsoft:master Aug 3, 2023
@xiaozhuai xiaozhuai deleted the dev-modern-cpp-kafka branch August 4, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] <morganstanley/modern-cpp-kafka>
4 participants