[stduuid] Update to 1.2.3 #33170
[stduuid] Update to 1.2.3 #33170
Conversation
Adela0814
added
the
category:port-update
ports/stduuid/portfile.cmake
Outdated
| ${FEATURE_OPTIONS} | ||
| ) | ||
| vcpkg_cmake_install() | ||
|
|
||
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/${PORT}) | ||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/lib) | ||
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/stduuid) |
There was a problem hiding this comment.
Please recover to ${PORT}.
There was a problem hiding this comment.
In contrast to other paths where we use the "${PORT}" placeholder, this path does not necessarily need to match the port name. It just happens to be identical here. So I thought it's better to be explicit and use "${PORT}" only where where the path really always matches the port name.
Otherwise, it seems pretty arbitrary to me when to use the placeholder and when not. E.g. why don't we use the placeholder here as well, then:
"${CURRENT_PACKAGES_DIR}/include/${PORT}/uuid.h"
There was a problem hiding this comment.
Changed it back to vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/${PORT}) in 98af66b.
|
All feature tested pass on the following triplets:
Usage tested pass on |
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
Updates stduuid to 1.2.3