Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perl] Update Strawberry Perl to 5.38.0.1 and switch to GitHub. #33854

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[perl] Update Strawberry Perl to 5.38.0.1 and switch to GitHub. #33854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/cmake/vcpkg_find_acquire_program(PERL).cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
set(program_name perl)
set(program_version 5.32.1.1)
set(program_version 5.38.0.1)
set(tool_subdirectory ${program_version})
set(paths_to_search ${DOWNLOADS}/tools/perl/${tool_subdirectory}/perl/bin)
set(brew_package_name "perl")
set(apt_package_name "perl")
set(download_urls
"https://strawberryperl.com/download/${program_version}/strawberry-perl-${program_version}-32bit.zip"
"https://github.com/StrawberryPerl/Perl-Dist-Strawberry/releases/download/SP_5380_5361/strawberry-perl-5.38.0.1-64bit-portable.zip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need extra guards, and extra announcements, due to requiring 64 bit hosts?
Should 32 bit hosts continue to use the old version?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32 bit builds do not currently exist but might yet be done. This is being tracked under StrawberryPerl/Perl-Dist-Strawberry#96

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already require 64 bit in a bunch of other places

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is the UX when users are on x86 windows hosts. If they don't even get to this point, fine. Otherwise, it should be handled in a way that doesn't create too many new issue reports. (Using the old download might be a good mitigation.)

)
set(download_filename "strawberry-perl-${program_version}-32bit.zip")
set(download_sha512 936381254fea2e596db6a16c23b08ced25c4081fda484e1b8c4356755016e4b956bd00f3d2ee651d5f41a7695e9998f6c1ac3f4a237212b9c55aca8c5fea14e9)
set(download_filename "strawberry-perl-5.38.0.1-64bit-portable.zip")
set(download_sha512 9b604f19e245a809bd18857bd91ebaec81ca031394ec69a3369df64d3590d2c9d557326d8aa10f91e78b1f1d56689aa57a8ec3a8cad4d2e542c96eb714a3831d)