Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opentelemetry-cpp] update to 1.12.0 #33983
[opentelemetry-cpp] update to 1.12.0 #33983
Changes from 41 commits
721dbcc
56fabca
2ddb224
c490686
ccdcbcd
56cb575
3a70322
fe2306e
b595375
98f68eb
060e43f
4673139
1733b88
98e74a3
a7e87db
b43be1b
70411a8
4ac1510
1295230
8c9dfe4
822f13e
07c8f0c
1663736
e51e574
dd4ae52
6827c15
6acc88a
aa30462
acbee17
72a9438
2c5555c
3efd269
6c652c7
fbe0fe3
f1eae05
e41d78a
a111f6b
cb68691
6846ffd
02fddf3
d33fa1c
dfd1d25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimwang118
What was the reason for removing this and adding the other features as dependencies? Now gRPC is included if otlp-http is included. I was previously trying to limit the size of the dependencies and I didn't want to include gRPC if I didn't have to. reverting these lines seems to fix my problem. Was this intended?