Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-cpp] update to 1.12.0 #33983

Merged
merged 42 commits into from
Oct 27, 2023
Merged
Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
721dbcc
Generate Imath.pc
jimwang118 Aug 17, 2023
56fabca
update version
jimwang118 Aug 17, 2023
2ddb224
add dependency imath minizip-ng
jimwang118 Aug 17, 2023
c490686
updata version
jimwang118 Aug 17, 2023
ccdcbcd
Merge branch 'microsoft:master' into master
jimwang118 Aug 18, 2023
56cb575
update
jimwang118 Aug 22, 2023
3a70322
update version
jimwang118 Aug 22, 2023
fe2306e
Merge branch 'microsoft:master' into master
jimwang118 Aug 23, 2023
b595375
Merge branch 'microsoft:master' into master
jimwang118 Aug 24, 2023
98f68eb
Merge branch 'microsoft:master' into master
jimwang118 Aug 25, 2023
060e43f
Merge branch 'microsoft:master' into master
jimwang118 Aug 28, 2023
4673139
Merge branch 'microsoft:master' into master
jimwang118 Aug 29, 2023
1733b88
Merge branch 'microsoft:master' into master
jimwang118 Aug 30, 2023
98e74a3
Merge branch 'microsoft:master' into master
jimwang118 Sep 1, 2023
a7e87db
Merge branch 'master' of https://github.com/Microsoft/vcpkg
jimwang118 Sep 4, 2023
b43be1b
Merge branch 'master' of https://github.com/Microsoft/vcpkg
jimwang118 Sep 11, 2023
70411a8
Merge branch 'microsoft:master' into master
jimwang118 Sep 14, 2023
4ac1510
Merge branch 'master' of https://github.com/Microsoft/vcpkg
jimwang118 Sep 15, 2023
1295230
update to 1.11.0
jimwang118 Sep 15, 2023
8c9dfe4
update version
jimwang118 Sep 15, 2023
822f13e
Merge branch 'master' of https://github.com/Microsoft/vcpkg
jimwang118 Sep 20, 2023
07c8f0c
update
jimwang118 Sep 25, 2023
1663736
update
jimwang118 Sep 25, 2023
e51e574
update version
jimwang118 Sep 25, 2023
dd4ae52
update version
jimwang118 Sep 25, 2023
6827c15
update version
jimwang118 Sep 25, 2023
6acc88a
Merge branch 'master' of https://github.com/Microsoft/vcpkg
jimwang118 Sep 26, 2023
aa30462
Merge branch 'master' of https://github.com/Microsoft/vcpkg
jimwang118 Sep 26, 2023
acbee17
Merge branch 'master' of https://github.com/jimwang118/vcpkg
jimwang118 Sep 26, 2023
72a9438
Merge branch 'master' of https://github.com/Microsoft/vcpkg
jimwang118 Sep 27, 2023
2c5555c
fix missing header file
jimwang118 Sep 27, 2023
3efd269
update version
jimwang118 Sep 27, 2023
6c652c7
Merge branch 'master' of https://github.com/Microsoft/vcpkg
jimwang118 Oct 8, 2023
fbe0fe3
Merge branch 'master' of https://github.com/Microsoft/vcpkg
jimwang118 Oct 10, 2023
f1eae05
Merge branch 'master' of https://github.com/Microsoft/vcpkg
jimwang118 Oct 11, 2023
e41d78a
Merge branch 'master' into update_opentelemtery-cpp
jimwang118 Oct 11, 2023
a111f6b
Merge branch 'update_opentelemtery-cpp' of https://github.com/jimwang…
jimwang118 Oct 11, 2023
cb68691
Fix feature otlp content
jimwang118 Oct 11, 2023
6846ffd
update version
jimwang118 Oct 11, 2023
02fddf3
update to 1.12.0
jimwang118 Oct 18, 2023
d33fa1c
update version
jimwang118 Oct 18, 2023
dfd1d25
update version
jimwang118 Oct 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions ports/opentelemetry-cpp/add-missing-include-file.patch

This file was deleted.

10 changes: 3 additions & 7 deletions ports/opentelemetry-cpp/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,14 @@ vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO open-telemetry/opentelemetry-cpp
REF "v${VERSION}"
SHA512 86cf0320f9ee50bc1aa2b7a8b254fb0df25d1bd1f5f01ebc3630ab7fe2f6ca5e53ca8e042518b4e7096dbb102c0b880e9a25fcdf5f668d24ff57d9247237bf62
SHA512 55553e3695adbc446264a4589fe8e3b2a284c0aac50ce2a09f76913bc8c0196b8ec8f79a32366c4473196332d4bff058793fe54ad2e95350fc046e3d148c8abb
HEAD_REF main
PATCHES
# Use the compiler's default C++ version. Picking a version with
# CMAKE_CXX_STANDARD is not needed as the Abseil port already picked
# one and propagates that version across all its downstream deps.
use-default-cxx-version.patch
# When compiling code generated by gRPC we need to link the gRPC library
# too.
add-missing-dependencies.patch
# Missing find_dependency for Abseil
add-missing-find-dependency.patch
add-missing-include-file.patch
)

vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
Expand All @@ -28,7 +23,6 @@ vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
prometheus WITH_PROMETHEUS
elasticsearch WITH_ELASTICSEARCH
jaeger WITH_JAEGER
otlp WITH_OTLP
jimwang118 marked this conversation as resolved.
Show resolved Hide resolved
otlp-http WITH_OTLP_HTTP
zpages WITH_ZPAGES
otlp-grpc WITH_OTLP_GRPC
Expand Down Expand Up @@ -63,6 +57,8 @@ vcpkg_cmake_configure(
${FEATURE_OPTIONS}
MAYBE_UNUSED_VARIABLES
WITH_OTLP_GRPC
WITH_JAEGER
WITH_LOGS_PREVIEW
)

vcpkg_cmake_install()
Expand Down
26 changes: 0 additions & 26 deletions ports/opentelemetry-cpp/use-default-cxx-version.patch

This file was deleted.

12 changes: 9 additions & 3 deletions ports/opentelemetry-cpp/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json",
"name": "opentelemetry-cpp",
"version-semver": "1.9.1",
"port-version": 1,
"version-semver": "1.12.0",
"description": [
"OpenTelemetry is a collection of tools, APIs, and SDKs.",
"You use it to instrument, generate, collect, and export telemetry data (metrics, logs, and traces) for analysis in order to understand your software's performance and behavior."
Expand Down Expand Up @@ -39,7 +38,14 @@
"otlp": {
"description": "Whether to include the OpenTelemetry Protocol in the SDK",
"dependencies": [
"protobuf"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimwang118

What was the reason for removing this and adding the other features as dependencies? Now gRPC is included if otlp-http is included. I was previously trying to limit the size of the dependencies and I didn't want to include gRPC if I didn't have to. reverting these lines seems to fix my problem. Was this intended?

{
"name": "opentelemetry-cpp",
"default-features": false,
"features": [
"otlp-grpc",
"otlp-http"
]
}
]
},
"otlp-grpc": {
Expand Down
26 changes: 26 additions & 0 deletions ports/opentelemetry-fluentd/fix_include_path.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
diff --git a/exporters/fluentd/src/log/recordable.cc b/exporters/fluentd/src/log/recordable.cc
index 5af84d8..1b124eb 100644
--- a/exporters/fluentd/src/log/recordable.cc
+++ b/exporters/fluentd/src/log/recordable.cc
@@ -1,6 +1,9 @@
/// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

+#include "opentelemetry/logs/severity.h"
+#include "opentelemetry/trace/span_id.h"
+#include "opentelemetry/trace/trace_id.h"
#include "opentelemetry/exporters/fluentd/log/recordable.h"
#include "opentelemetry/exporters/fluentd/common/fluentd_common.h"
#include "opentelemetry/exporters/fluentd/common/fluentd_logging.h"
diff --git a/exporters/fluentd/src/trace/recordable.cc b/exporters/fluentd/src/trace/recordable.cc
index 5c0a5ed..c24aa0c 100644
--- a/exporters/fluentd/src/trace/recordable.cc
+++ b/exporters/fluentd/src/trace/recordable.cc
@@ -4,6 +4,7 @@
#include "opentelemetry/exporters/fluentd/trace/recordable.h"
#include "opentelemetry/exporters/fluentd/common/fluentd_common.h"
#include "opentelemetry/exporters/fluentd/common/fluentd_logging.h"
+#include "opentelemetry/sdk/resource/resource.h"

#include <map>
#include <string>
2 changes: 2 additions & 0 deletions ports/opentelemetry-fluentd/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ vcpkg_from_github(
REF 7afa91952f08aad1fa79b8992f20a4b0cdaadaff # Maps to 2.0.0
HEAD_REF main
SHA512 b28415c867aee5efe99f7521a145b5c402ac555d83be75a8b1d2760aed226ac109a6d092e86d7afedcc2ed8dc848d9662ac6505133d32f99b810f51e2748d1fc
PATCHES
fix_include_path.patch
)

vcpkg_cmake_configure(
Expand Down
1 change: 1 addition & 0 deletions ports/opentelemetry-fluentd/vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json",
"name": "opentelemetry-fluentd",
"version-semver": "2.0.0",
"port-version": 1,
"description": "mdsd/fluentd exporter for OpenTelemetry C++",
"homepage": "https://github.com/open-telemetry/opentelemetry-cpp-contrib/tree/main/exporters",
"license": "Apache-2.0",
Expand Down
6 changes: 3 additions & 3 deletions versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -6201,12 +6201,12 @@
"port-version": 0
},
"opentelemetry-cpp": {
"baseline": "1.9.1",
"port-version": 1
"baseline": "1.12.0",
"port-version": 0
},
"opentelemetry-fluentd": {
"baseline": "2.0.0",
"port-version": 0
"port-version": 1
},
"opentracing": {
"baseline": "1.6.0",
Expand Down
10 changes: 10 additions & 0 deletions versions/o-/opentelemetry-cpp.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
{
"versions": [
{
"git-tree": "5fd8cacd9fd3aaa30b0ad133f2de052ba3ff869f",
"version-semver": "1.12.0",
"port-version": 0
},
{
"git-tree": "73b513869768adc1fa546e6c96b823694ece9f08",
"version-semver": "1.11.0",
"port-version": 0
},
jimwang118 marked this conversation as resolved.
Show resolved Hide resolved
jimwang118 marked this conversation as resolved.
Show resolved Hide resolved
{
"git-tree": "3ad2a8625bd852a203f6156970c0eada6f90c192",
"version-semver": "1.9.1",
Expand Down
5 changes: 5 additions & 0 deletions versions/o-/opentelemetry-fluentd.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "e9ffc101ca11ffd64b1a2bd73ae7e11bf7f28cfc",
"version-semver": "2.0.0",
"port-version": 1
},
{
"git-tree": "4c8cdb3314a3a35268d4ce9b786c6632c79e0f97",
"version-semver": "2.0.0",
Expand Down