Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crc32c] add license #34516

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[crc32c] add license #34516

merged 2 commits into from
Nov 8, 2023

Conversation

Lex-2008
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Lex-2008 Lex-2008 changed the title Lic/crc32c Add crc32c license Oct 16, 2023
@Cheney-W Cheney-W added the category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. label Oct 17, 2023
@Lex-2008 Lex-2008 changed the title Add crc32c license [crc32c] add license Oct 17, 2023
@Cheney-W
Copy link
Contributor

@Lex-2008
Could you sign our Contributor License Agreement based on the robot's prompts?

@Lex-2008
Copy link
Contributor Author

Thanks for the reminder, @Cheney-W! Sorry for the delay, need to sync with my employer first.

@Lex-2008
Copy link
Contributor Author

Lex-2008 commented Nov 8, 2023

@microsoft-github-policy-service agree company="reMarkable"

@Lex-2008 Lex-2008 marked this pull request as ready for review November 8, 2023 09:48
@Lex-2008
Copy link
Contributor Author

Lex-2008 commented Nov 8, 2023

Sorry for the delay, signed now!

@Cheney-W: do you want me to rebase these changes to latest master, or is this PR fine as is?

@Cheney-W
Copy link
Contributor

Cheney-W commented Nov 8, 2023 •
edited
Loading

No.
This PR is fine.

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Nov 8, 2023
@JavierMatosD JavierMatosD merged commit fbe824c into microsoft:master Nov 8, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lex-2008 @Cheney-W @JavierMatosD