[fmt] add option FMT_MODULE #34661
Closed
[fmt] add option FMT_MODULE #34661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
reviewed
Oct 22, 2023
ports/fmt/portfile.cmake
Outdated
Comment on lines
12
to
16
| if ("modules" IN_LIST FEATURES) | ||
| set(CXX_MODULES enabled) | ||
| else() | ||
| set(CXX_MODULES disabled) | ||
| endif() |
There was a problem hiding this comment.
This is not a valid options value. It must be ON or OFF. Additionally this is not a feature but an option: https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#do-not-use-features-to-implement-alternatives
Depends on #22216
There was a problem hiding this comment.
I have updated the on off mixup, however I can see that this approach has already been discussed and rejected in #32572
Adela0814
added
the
category:port-feature
omarhogni
force-pushed
the
fmt_modules
branch
from
a9c4942 to
c62cb3e
Compare
|
Pinging @omarhogni for response. Is work still being done for this PR? |
No, this can be closed I am unsure how this should be implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.