Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python3] Fix lld-link and add port config for python site #36245

Merged
merged 2 commits into from
Jan 19, 2024
Merged

[python3] Fix lld-link and add port config for python site #36245

merged 2 commits into from
Jan 19, 2024

Conversation

Neumann-A
Copy link
Contributor

  • Changes comply with the maintainer guide
  • [-] SHA512s are updated for each updated download
  • [-] The "supports" clause reflects platforms that may be fixed by this new version
  • [-] Any fixed CI baseline entries are removed from that file.
  • [-] Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Jan 19, 2024
@JavierMatosD JavierMatosD merged commit 915ebaf into microsoft:master Jan 19, 2024
15 checks passed
@Neumann-A Neumann-A deleted the python_add_port_config branch January 19, 2024 21:20
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
@Neumann-A @Osyotr
[python3] Fix lld-link and add port config for python site (microsoft…
0d35af6 
…#36245)

* [python3] remove duplicated symbols for lld-link and add port config

* v db
@JonLiu1993
Copy link
Member

JonLiu1993 commented Jan 25, 2024 •
edited
Loading

@Neumann-A, This PR merge resulted in a CI regression:

REGRESSION: lensfun:x64-linux failed with BUILD_FAILED

I can reproduce this error locally using the latest vcpkg. Could you please take a look?

@dg0yt
Copy link
Contributor

dg0yt commented Jan 25, 2024

lensfun: #36342

@JonLiu1993
Copy link
Member

lensfun: #36342

Thanks for your timely and powerful repair.

TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
@Neumann-A @TomKatom
[python3] Fix lld-link and add port config for python site (microsoft…
7e523bf 
…#36245)

* [python3] remove duplicated symbols for lld-link and add port config

* v db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Neumann-A @JonLiu1993 @dg0yt @MonicaLiu0311 @JavierMatosD