Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openmesh] Update to 10.0 and apply more love #36540

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

Osyotr
Copy link
Contributor

@Osyotr Osyotr commented Feb 3, 2024

Changelog: https://www.graphics.rwth-aachen.de/media/openmesh_static/Documentations/OpenMesh-Doc-Latest/a06138.html

  • Don't copy binaries to packages root (VCI_COMMON_DO_NOT_COPY_POST_BUILD)
  • Don't install library twice (VCI_NO_LIBRARY_INSTALL)
  • Fix pkgconfig by adding debug suffix
  • Don't build and install static and shared binaries simultaneously on linux (also fixes x64-linux-dynamic)

Note: download URL for some reason contains 10.0.0 instead of 10.0, but AFAICT version scheme has not been changed.

@Osyotr Osyotr force-pushed the openmesh-fixes branch 2 times, most recently from 3d6493d to 85d5d63 Compare February 3, 2024 01:10
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 4, 2024
@MonicaLiu0311
Copy link
Contributor

MonicaLiu0311 commented Feb 4, 2024

The usage test passed on x64-windows and x64-windows-static (header files found), can also be found via pkg_check_modules():

openmesh provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(OpenMesh CONFIG REQUIRED)
  target_link_libraries(main PRIVATE OpenMeshCore OpenMeshTools)

openmesh provides pkg-config modules:

    # OpenMesh library
    openmesh

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Feb 4, 2024
@data-queue data-queue merged commit 406d612 into microsoft:master Feb 6, 2024
16 checks passed
@Osyotr Osyotr deleted the openmesh-fixes branch February 6, 2024 21:45
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
* [openmesh] Update to 10.0 and apply more love

* Fix osx build (restore c++11 compatibility)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants