Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[community triplet] Add x64-windows-static-md-release triplet #37116

Merged

Conversation

LiuPeiqiCN
Copy link
Contributor

This adds a x64-windows-static-md-release triplet.

@FrankXie05 FrankXie05 added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Mar 4, 2024
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE static)

set(VCPKG_BUILD_TYPE release)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set(VCPKG_BUILD_TYPE release)
set(VCPKG_BUILD_TYPE release)

We need to add the end line otherwise it will appear in red. :)

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Mar 4, 2024
@vicroms vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Mar 5, 2024
@vicroms
Copy link
Member

vicroms commented Mar 8, 2024

Hi @LiuPeiqiCN

As stated in the maintainer guide we don't want PRs that add community triplets just to "fill out the empty spaces".

We will add community triplets if:
eee

  • It is demonstrated that people will actually use that community triplet; and,
  • we don't know that such a triplet is broken.

Do you know if there's a group of people that is interested in having this community triplet available?

@LiuPeiqiCN
Copy link
Contributor Author

Hi @vicroms
Nowadays, it's generally recommended to use /MD dynamic libraries instead of /MT static libraries. However, there are still situations where static linking is necessary to avoid excessive DLL dependencies and DLL hell. Additionally, static linking can offer better performance. In such cases, I need statically linked libraries with the /MD compiler option enabled. However, static library compilation consumes a significant amount of time, which can be painful during DEBUG builds that require frequent compilation. Therefore, the need arises to link dynamic libraries in DEBUG mode and /MD static libraries in RELEASE mode, which is the origin of this x64-windows-static-md-release triplet.
However, this is currently based solely on my personal needs, and I'm not sure if others are interested in this approach.

@vicroms vicroms removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Mar 8, 2024
@vicroms
Copy link
Member

vicroms commented Mar 8, 2024

Thanks for the response!

@vicroms vicroms merged commit 7c49e96 into microsoft:master Mar 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants