-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtkm|vtk|paraview] update ports #37119
Merged
Merged
Changes from 154 commits
Commits
Show all changes
168 commits
Select commit
Hold shift + click to select a range
ac1f57e
force bla vendor in blas
Neumann-A f2df1fa
force BLA_VENDOR for lapack.
Neumann-A f14cac7
fix wrapper install
Neumann-A 995f5b2
add version info
Neumann-A b92ef3b
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
ef59437
install wrapper if not exist.
d887061
cleanup stuff
c12bad7
rename to cmake.in
c50945d
details
16373d0
drastically simplify FindLAPACK by clapack
9759dd2
no find_dependency in modules!
a8df6e7
add missing @ONLY
1e1819c
move stuff around
63b429d
fix platform expr
dc751ce
be consistent as the comment says
6feaf6b
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A 677cb68
rename test ports with -test
Neumann-A 5fe252b
use version-string to define blas impl.
Neumann-A 272a28c
add version stuff
Neumann-A 0fe4af8
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
ef73585
more pc files
d58573d
version stuff
244878c
adjust test to check for pc files.
55d4d09
revert openblas version
b7c002b
fix copy pasta
d77a77e
fix uwp regression
Neumann-A 9896014
version stuff
Neumann-A 4c2e724
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A f0b472c
cleanup
Neumann-A bbf8ace
fix logic
Neumann-A 1044e8d
fine tuning
Neumann-A b4e1bfc
format manifest
Neumann-A 4b0a163
v db
Neumann-A e2193ee
fix platform expression
Neumann-A b40a3a9
overwrite version
Neumann-A 1052fc6
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A eba70b8
Merge branch 'microsoft:master' into force_bla_vendor
Neumann-A 499886c
Merge branch 'microsoft:master' into force_bla_vendor
Neumann-A 09ddd5e
fix mlpack by fixing armadillo config.
Neumann-A 3cd56c9
v db
Neumann-A 4339948
add licens to clapack
Neumann-A 76c27e2
v db
Neumann-A f562fcb
Merge branch 'microsoft:master' into force_bla_vendor
Neumann-A 8ab457d
Merge branch 'microsoft:master' into force_bla_vendor
Neumann-A a1ed890
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A aa79c87
bump port versions
Neumann-A 41111e1
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A f3688f5
fix release pc path
Neumann-A 7d7b076
fix urls
Neumann-A 6d4ec44
Merge branch 'microsoft:master' into force_bla_vendor
Neumann-A d7485f8
v db
Neumann-A 1b3df81
v db the rest
Neumann-A 7ae0409
ci baseline
Neumann-A ad9405a
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A 0ceb6ca
v db
Neumann-A fd64330
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A 5e5852d
v db
Neumann-A f455709
trace failures
Neumann-A e838da1
add cblas feature as a dependency in static builds
Neumann-A f1aef26
Slip cblas into lapack for opencv.
Neumann-A e947d22
format manifest
Neumann-A e2e85f2
v db
Neumann-A 9b41be6
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A affdd7e
revert debug changes
Neumann-A a9f6f57
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A 164ec71
v db
Neumann-A 6e12241
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A 2637ba6
v db
Neumann-A 29fdcb5
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal ddac191
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A 5e89b43
v db
Neumann-A 2699c49
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A 912b5d0
v db
Neumann-A b47cadb
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A cc03e3d
v db
Neumann-A 66a0139
update vtkm
Neumann-A 5f0b071
update vtk
Neumann-A 93711b0
update paraview
Neumann-A 089116e
fix patch
Neumann-A e2b33a5
Fix transitiv deps in openturns
Neumann-A b6453de
include fix for paraview configure/build
Neumann-A d41e07c
adjust prebuild install for vtk
Neumann-A b29e4a3
fix nlopt variables being one too deep
Neumann-A 8bcfee7
more dep fixes
Neumann-A ec9651a
adjust python install dir and qt5 typo
Neumann-A b6ad74b
trying to fix the deps
Neumann-A 64ecb4f
Fix eigen3 target check.
Neumann-A 6a1fff3
format manifest
Neumann-A f96d3b1
add another dep
Neumann-A 5cefee7
get trace output for debugging deps
Neumann-A 6db8250
Merge branch 'microsoft:master' into force_bla_vendor
Neumann-A e0a945c
adjust dlib for linux
Neumann-A bc45c6d
fix theia and dbow2 ?
Neumann-A 8bec786
devondor exodus and trace
Neumann-A 7d46e80
burn in linkage in openturns
Neumann-A 30ba4c1
fix ot in vtk
Neumann-A 2298ce7
Fix paraview
Neumann-A 408ef74
allow dll in static build
Neumann-A cb44ad5
Fix post build on !windows
Neumann-A b1717a4
trying to fix post build
Neumann-A 3cf0b9d
enable modules so VTK components get correctly looked up.
Neumann-A 95052b8
do not touch the prefix
Neumann-A ed9f0f5
disable fortran
Neumann-A 436a582
check optional deps explicitly
Neumann-A a99872b
trace openvms
Neumann-A 343d986
remove invalid cblas patch in shogun
Neumann-A b8d73a3
adjust ci baseline
Neumann-A 0a131bf
Fix shogun?
Neumann-A 58f503d
add missing lapack dep
Neumann-A 481085f
remove flags being nuked by shogun
Neumann-A 9175648
fix accelerate detection
Neumann-A dd61a83
a bit of debugging shogun
Neumann-A 771e1e4
run trace
Neumann-A 42eb54e
retry with different regex
Neumann-A 1f7cefd
disable lapack/blas usage for eigen on osx
Neumann-A 31284db
v db
Neumann-A 4e099b5
Merge branch 'microsoft:master' into paraview_5.12
Neumann-A b6710db
revert eigen3 and openmvs
Neumann-A b75e989
fix optional modules
Neumann-A 0a3aa4f
remove hack due to upstream patch
Neumann-A e92b975
Merge remote-tracking branch 'upstream/master' into paraview_5.12
Neumann-A 84c5fb0
update patch
Neumann-A 752e8fc
v db
Neumann-A 750bcde
add newline to patch
Neumann-A 6773356
v db
Neumann-A 4f06be1
reenable trace
Neumann-A 7698be2
enable python catalyst
Neumann-A dfbf132
make the variable a STRING
Neumann-A fc25dc0
more vtk fixes
Neumann-A e1273ab
Merge remote-tracking branch 'upstream/master' into force_bla_vendor
Neumann-A 36c0019
add cblas port
Neumann-A e0bab30
v db
Neumann-A 32210cc
Merge remote-tracking branch 'upstream/master' into paraview_5.12
Neumann-A b2ebecd
Merge remote-tracking branch 'origin/force_bla_vendor' into paraview_…
Neumann-A c2c141b
mod ci baseline
Neumann-A 2dcda9e
Fix python3 in VTK
Neumann-A c5e2b25
add /PDBPAGESIZE:8192 to static windows builds.
Neumann-A 774b30c
trace openmvs
Neumann-A 97f0d02
Merge branch 'microsoft:master' into paraview_5.12
Neumann-A 0ecbd7a
hack static builds to work.
Neumann-A cf8fc44
Merge branch 'paraview_5.12' of https://github.com/Neumann-A/vcpkg in…
Neumann-A cb4bca5
bump port version
Neumann-A 6593059
add new patch to paraview
Neumann-A 25bb398
v db
Neumann-A ecf9312
remove upstream patch again since it does not apply cleanly
Neumann-A 9caf118
v db
Neumann-A 97c3678
revert wrong baseline entry
Neumann-A 6c8d477
revert CI baseline
Neumann-A 23e11c0
Merge remote-tracking branch 'upstream/master' into paraview_5.12
Neumann-A 7995080
v db
Neumann-A 33587b7
v db
Neumann-A 922f4d2
fix patch
Neumann-A eb5f733
v db
Neumann-A d33c96d
Merge remote-tracking branch 'upstream/master' into paraview_5.12
Neumann-A 32bb6a4
Merge remote-tracking branch 'origin/master' into HEAD
BillyONeal f15c3c9
v db
Neumann-A 818ab66
Apply suggestions from code review
Neumann-A 40ff109
Merge branch 'paraview_5.12' of github.com:Neumann-A/vcpkg into parav…
Neumann-A 169b16c
Merge remote-tracking branch 'upstream/master' into paraview_5.12
Neumann-A bfdbbf1
v db
Neumann-A 4678b96
Merge branch 'microsoft:master' into paraview_5.12
Neumann-A 6f4248a
Merge branch 'microsoft:master' into paraview_5.12
Neumann-A a35d9cd
Merge remote-tracking branch 'upstream/master' into paraview_5.12
Neumann-A 10d38e1
v db
Neumann-A 195b2a0
[lapack-reference] re-add cblas libraries to wrapper
Neumann-A 74fbefd
v db
Neumann-A 9f7d372
look for correct cblas name
Neumann-A a1a26ef
v db
Neumann-A File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index 39ec359ac3..03225b8940 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -177,10 +177,10 @@ if(Boost_FOUND) | ||
LIST(APPEND OpenMVS_DEFINITIONS -D_USE_BOOST) | ||
ADD_DEFINITIONS(${Boost_DEFINITIONS}) | ||
LINK_DIRECTORIES(${Boost_LIBRARY_DIRS}) | ||
- if(NOT MSVC AND DEFINED CMAKE_TOOLCHAIN_FILE) | ||
- # work around this missing library link in vcpkg | ||
- LIST(APPEND Boost_LIBRARIES zstd) | ||
- endif() | ||
+ LINK_LIBRARIES(${Boost_LIBRARIES}) | ||
+ find_package(zstd CONFIG REQUIRED) | ||
+ LINK_LIBRARIES($<IF:$<TARGET_EXISTS:zstd::libzstd_shared>,zstd::libzstd_shared,zstd::libzstd_static>) | ||
+ | ||
SET(_USE_BOOST TRUE) | ||
endif() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
diff --git a/CMake/vtkModuleWrapClientServer.cmake b/CMake/vtkModuleWrapClientServer.cmake | ||
index cba0380cd9..9c8bbc5084 100644 | ||
--- a/CMake/vtkModuleWrapClientServer.cmake | ||
+++ b/CMake/vtkModuleWrapClientServer.cmake | ||
@@ -72,8 +72,8 @@ function (_vtk_module_wrap_client_server_sources module sources classes) | ||
"guarantee intended behavior.") | ||
endif () | ||
endif () | ||
- file(GENERATE OUTPUT "compile_definitions_${_vtk_client_server_target_name}" CONTENT "${_vtk_client_server_genex_compile_definitions_all}") | ||
- file(GENERATE OUTPUT "include_directories_${_vtk_client_server_target_name}" CONTENT "${_vtk_client_server_genex_include_directories_all}") | ||
+ file(GENERATE OUTPUT "compile_definitions_${_vtk_client_server_library_name}" CONTENT "${_vtk_client_server_genex_compile_definitions_all}") | ||
+ file(GENERATE OUTPUT "include_directories_${_vtk_client_server_library_name}" CONTENT "${_vtk_client_server_genex_include_directories_all}") | ||
file(GENERATE | ||
OUTPUT "${_vtk_client_server_args_file}" | ||
CONTENT "$<$<BOOL:${_vtk_client_server_genex_compile_definitions_all}>:\n-D\'$<JOIN:${_vtk_client_server_genex_compile_definitions_all},\'\n-D\'>\'>\n | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index 1be00fb71a..c47cf20d55 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -68,7 +68,7 @@ if (PARAVIEW_USE_EXTERNAL_VTK) | ||
"External VTK not found but ParaView requires VTK to function") | ||
endif () | ||
if (NOT PARAVIEW_BUILD_SHARED_LIBS) | ||
- message(FATAL_ERROR | ||
+ message(WARNING | ||
"Static build with external VTK does not currently work.") | ||
endif() | ||
get_filename_component(vtk_cmake_dir "${VTK_CONFIG}" DIRECTORY) | ||
diff --git a/Utilities/PythonInterpreterPath/vtkPVPythonInterpreterPath.cxx b/Utilities/PythonInterpreterPath/vtkPVPythonInterpreterPath.cxx | ||
index 06e517964b..fbf9f5c2df 100644 | ||
--- a/Utilities/PythonInterpreterPath/vtkPVPythonInterpreterPath.cxx | ||
+++ b/Utilities/PythonInterpreterPath/vtkPVPythonInterpreterPath.cxx | ||
@@ -13,8 +13,9 @@ extern "C" | ||
void vtkPVInitializePythonModules(); | ||
void VTKUTILITIESPYTHONINTERPRETERPATH_EXPORT vtkPVPythonInterpreterPath() | ||
{ | ||
- std::string libraryPath = vtkGetLibraryPathForSymbol(vtkPVInitializePythonModules); | ||
- vtkPythonInterpreter::SetUserPythonPath( | ||
- libraryPath.c_str(), "paraview/__init__.py" /*landmark*/); | ||
+ // Ignore this for now. Requires a slightly newer VTK version than PV 5.12 uses. | ||
+ //std::string libraryPath = vtkGetLibraryPathForSymbol(vtkPVInitializePythonModules); | ||
+ //vtkPythonInterpreter::SetUserPythonPath( | ||
+ // libraryPath.c_str(), "paraview/__init__.py" /*landmark*/); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index 1b9fd80..94ad133 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -557,7 +557,16 @@ if (PARAVIEW_USE_EXTERNAL_VTK) | ||
endforeach() | ||
endmacro() | ||
search_dependent_targets(${vtk_modules}) | ||
- find_package(VTK CONFIG REQUIRED COMPONENTS "${vtk_components}") | ||
+ | ||
+ if (PARAVIEW_USE_PYTHON) | ||
+ get_target_property(vtk_python_modules VTK::vtkpythonmodules "INTERFACE_LINK_LIBRARIES") | ||
+ list(TRANSFORM vtk_python_modules REPLACE "Python$" "" OUTPUT_VARIABLE vtk_modules_wrapped) | ||
+ list(TRANSFORM vtk_modules_wrapped REPLACE "^VTK::vtk" "" OUTPUT_VARIABLE vtk_components_wrapped) | ||
+ list(APPEND vtk_components ${vtk_components_wrapped}) | ||
+ list(REMOVE_DUPLICATES vtk_components) | ||
+ endif() | ||
+ | ||
+ find_package(VTK CONFIG REQUIRED COMPONENTS "${vtk_components}") | ||
if (PARAVIEW_USE_PYTHON) | ||
find_package(Python3 3.3 QUIET REQUIRED COMPONENTS Interpreter) | ||
set(PYTHON_VERSION_MAJOR "${Python3_VERSION_MAJOR}") | ||
diff --git a/Qt/Python/vtk.module b/Qt/Python/vtk.module | ||
index f82f076..86dbafd 100644 | ||
--- a/Qt/Python/vtk.module | ||
+++ b/Qt/Python/vtk.module | ||
@@ -12,7 +12,7 @@ GROUPS | ||
PARAVIEW_CANONICAL | ||
DEPENDS | ||
ParaView::pqCore | ||
- ParaView::PythonInitializer | ||
+ #ParaView::PythonInitializer <- Creates a cycle | ||
BillyONeal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
VTK::PythonInterpreter | ||
VTK::WrappingPythonCore | ||
TEST_LABELS |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why it is acceptable to just comment stuff out like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens here in C++ code is the equivalent of setting
PYTHONPATH
in the environment. Since the VTK version here does not have these functions yet I commented them out. It is basically a partial revert of the external VTK patch in iparaview. (The current version of paraview also does not have these setup functions.)Basically: It is a nice to have for paraview to have these functions but they are not a requirement. Users can manually set them up (or screw them up).