Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x264] Update to 0.164.3108, use official upstream #39460

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jun 23, 2024

Using the last commit in branch stable.

@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Jun 24, 2024
LilyWangLL
LilyWangLL previously approved these changes Jun 24, 2024
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 24, 2024
+++ b/configure
@@ -1,4 +1,7 @@
-#!/bin/bash
+/usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+/usr/bin/env bash
+#!/usr/bin/env bash

Doesn't it still need to be a shebang?

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Me needs more sleep. Thanks for catching.

This comment was marked as outdated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! :)

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM except for the shebang thing.... about which I admit I am extremely underinformed...

# Conflicts:
#	scripts/ci.baseline.txt
@BillyONeal BillyONeal merged commit 467f9a6 into microsoft:master Jun 26, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks!

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jun 26, 2024
[x264] Update to 0.164.3108, use official upstream (microsoft#39460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants